Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImproved README.md #1757
Open
Improved README.md #1757
Conversation
|
I'm not a maintainer, but I saw this and just left some comments anyway. |
|
|
||
| [](https://gitpod.io/#https://github.com/TheAlgorithms/Java) | ||
|
|
||
|
|
||
| ### All algorithms are implemented in Java (for educational purposes) | ||
| These implementations are for learning purposes. The implementations may be less efficient than the Java standard library. | ||
| This implementations are only for learning purposes. The implementations is probably less efficient than the Java standard library. |
SethiPandi
Oct 15, 2020
The old sentence was perfectly fine, the new one is grammatically incorrect.
The old sentence was perfectly fine, the new one is grammatically incorrect.
|
|
||
| ## Contribution Guidelines | ||
| Read our [Contribution Guidelines](CONTRIBUTING.md) before you contribute. | ||
|
|
||
| ## Community Channel | ||
| We're on [Gitter](https://gitter.im/TheAlgorithms)! Please join us. | ||
| We are on [Gitter](https://gitter.im/TheAlgorithms)! Please join us. |
SethiPandi
Oct 15, 2020
This isn't an improvement at all, apostrophes are good things.
This isn't an improvement at all, apostrophes are good things.
| @@ -3,21 +3,21 @@ | |||
| [](https://gitter.im/TheAlgorithms) | |||
|
|
|||
|
|
|||
| NOTE: A [Development](https://github.com/TheAlgorithms/Java/tree/Development) branch is made for this repo where we're trying to migrate the existing project to a Java project structure. You can switch to [Development](https://github.com/TheAlgorithms/Java/tree/Development) branch for contributions. Please refer [this issue](https://github.com/TheAlgorithms/Java/issues/474) for more info. | |||
| NOTE: A [Development](https://github.com/TheAlgorithms/Java/tree/Development) branch is made for this repo where we are trying are best to migrate the existing project to a Java project structure. You can switch to [Development](https://github.com/TheAlgorithms/Java/tree/Development) branch for contributions. Please refer [this issue](https://github.com/TheAlgorithms/Java/issues/474) for more info. | |||
SethiPandi
Oct 15, 2020
This is also grammatically incorrect.
Also it's "our best" not "are best".
This is also grammatically incorrect.
Also it's "our best" not "are best".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.