Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate reverse.java #1802
Open
Create reverse.java #1802
Conversation
|
The naming style of the file looks ambiguous to me. |
|
Why sir
…On Fri, 16 Oct 2020, 23:58 Sai Kumar, ***@***.***> wrote:
The naming style of the file looks ambiguous to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1802 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARB7X4VHYR5GNDE4775ROHDSLCGDPANCNFSM4SS3WBXQ>
.
|
|
I believe that the naming of the file should be intuitive. What would someone make of a file named just reverse? |
|
Sir I think it's very normal to name such files I think you unreasonably
doubtful otherwise it's your choice whether you merge my file or not
…On Sat, 17 Oct 2020, 01:37 Sai Kumar, ***@***.***> wrote:
I believe that the naming of the file should be intuitive. What would
someone make of a file named just reverse?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1802 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARB7X4T7M76ZGARCFGN34OTSLCRXLANCNFSM4SS3WBXQ>
.
|
|
|
I simply created scanner to get input from the user
…On Sat, Oct 17, 2020 at 5:11 AM Seth ***@***.***> wrote:
- The code is messy.
- It doesn't follow Java naming conventions.
- The file doesn't have a useful name.
- There is no link to the algorithm being implemented.
- Why did you create a scanner?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1802 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARB7X4TMVU7QLSOOAP3XMB3SLDKYZANCNFSM4SS3WBXQ>
.
|
|
and Regarding the name of the file I now get it where I am wrong !!.So
thank you for helping
On Sat, Oct 17, 2020 at 9:46 AM sarthak jain <[email protected]>
wrote:
… I simply created scanner to get input from the user
On Sat, Oct 17, 2020 at 5:11 AM Seth ***@***.***> wrote:
>
> - The code is messy.
> - It doesn't follow Java naming conventions.
> - The file doesn't have a useful name.
> - There is no link to the algorithm being implemented.
> - Why did you create a scanner?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1802 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARB7X4TMVU7QLSOOAP3XMB3SLDKYZANCNFSM4SS3WBXQ>
> .
>
|
You aren't getting input from the user, though? |
|
okay sir i now get my mistake
…On Sat, Oct 17, 2020 at 1:33 PM Seth ***@***.***> wrote:
I simply created scanner to get input from the user
… <#m_387827868157510220_>
On Sat, Oct 17, 2020 at 5:11 AM Seth *@*.***> wrote: - The code is messy.
- It doesn't follow Java naming conventions. - The file doesn't have a
useful name. - There is no link to the algorithm being implemented. - Why
did you create a scanner? — You are receiving this because you authored the
thread. Reply to this email directly, view it on GitHub <#1802 (comment)
<#1802 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARB7X4TMVU7QLSOOAP3XMB3SLDKYZANCNFSM4SS3WBXQ
.
You aren't getting input from the user, though?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1802 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARB7X4XXTWPPNBBV2DU2DHTSLFFV5ANCNFSM4SS3WBXQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.