The Wayback Machine - https://web.archive.org/web/20201103183525/https://github.com/TheAlgorithms/Java/pull/1805
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Calculator #1805

Open
wants to merge 1 commit into
base: master
from
Open

Java Calculator #1805

wants to merge 1 commit into from

Conversation

@ts9415
Copy link

@ts9415 ts9415 commented Oct 16, 2020

Calculator made using java code. Happy to share with you sir.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Calculator made using java code. Happy to share with you sir.
@SethiPandi
Copy link

@SethiPandi SethiPandi commented Oct 16, 2020

This isn't much of an algorithm.
Not sure if it belongs in this repository.

On the side though, I think taking the library approach would be more friendly for this repository as well, so rather than use scanner, you could make a method which takes parameters and show example usages of your function instead.

@ts9415
Copy link
Author

@ts9415 ts9415 commented Oct 17, 2020

ok sir i will do it soon

This isn't much of an algorithm.
Not sure if it belongs in this repository.

On the side though, I think taking the library approach would be more friendly for this repository as well, so rather than use scanner, you could make a method which takes parameters and show example usages of your function instead.

ok sir i will do it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.