The Wayback Machine - https://web.archive.org/web/20201103183504/https://github.com/TheAlgorithms/Java/pull/1823
Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkedList arguments #1823

Open
wants to merge 4 commits into
base: master
from
Open

LinkedList arguments #1823

wants to merge 4 commits into from

Conversation

@joshiii947
Copy link

@joshiii947 joshiii947 commented Oct 17, 2020 •
edited

Describe your change:

Added return type for another type in the request .If you feel any problem please let me know

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
joshiii947 added 3 commits Oct 17, 2020
@joshiii947
linkedlist arguments
c0eb33e
@joshiii947
linkedlist arguments
930b1f6
@joshiii947
linkedlist arguments
c45c8ec
@psvnlsaikumar
psvnlsaikumar reviewed Oct 17, 2020
View changes
Copy link

@psvnlsaikumar psvnlsaikumar left a comment

Isn't the previous code doing the same thing? I can only see the difference in return. But in essence both look the same.
You did not have to remove a new list declaration from line 14 and add it to line 40.
@joshiii947
perfect square
246e7b3
@joshiii947
Copy link
Author

@joshiii947 joshiii947 commented Oct 17, 2020

ok understand it .next time do it better .Can you please check out the method of perfect method pull request .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psvnlsaikumar psvnlsaikumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@joshiii947 @psvnlsaikumar
You can’t perform that action at this time.