The Wayback Machine - https://web.archive.org/web/20201103183310/https://github.com/TheAlgorithms/Java/pull/1918
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Fibonacci Search in Java #1918

Open
wants to merge 1 commit into
base: master
from

Conversation

@sumitaccess007
Copy link

@sumitaccess007 sumitaccess007 commented Oct 23, 2020

Implementation of Fibonacci Search in Java:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@sumitaccess007
Copy link
Author

@sumitaccess007 sumitaccess007 commented Oct 23, 2020

Hi,

In Java under Search Algorithms, I found Fibonacci Search missing, as per the contribution guidelines I have submitted a PR without creating issue first and then asking for assigning it.
Thanks to review and let me know if any improvement is required.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.