The Wayback Machine - https://web.archive.org/web/20201103183153/https://github.com/TheAlgorithms/Java/pull/1981
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new file to string directory #1981

Open
wants to merge 1 commit into
base: master
from

Conversation

@DEVELOPER-IN-PROGRESS
Copy link

@DEVELOPER-IN-PROGRESS DEVELOPER-IN-PROGRESS commented Oct 29, 2020

uploaded Piglatin game in java

Describe your change:

  • [X ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
uploaded Piglatin game in java
import java.util.Arrays;
public class piglatinGame
{
public static void main(String[] args)

This comment has been minimized.

@AkMo3

AkMo3 Oct 30, 2020

main method should not used. Create function and make it public so as to access.

@@ -0,0 +1,34 @@
import java.util.Arrays;
public class piglatinGame
{

This comment has been minimized.

@AkMo3

AkMo3 Oct 30, 2020

Add javadoc comments. You can refer to Java-Documentation Comments. Also refer to this file to analyse the format of code DecimalToAnyBase.java

{
try
{
if (args[0] == null )

This comment has been minimized.

@AkMo3

AkMo3 Oct 30, 2020

Use scanner or bufferedReader class instead of {args} command line input may not be given, and directly function may be called.

}

String s = args[0];
s = s + "-ay" ;

This comment has been minimized.

@AkMo3

AkMo3 Oct 30, 2020

This is not piglatin. Read the concept of piglatin carefully.
In piglatin you find the first vowel and then shift all the words in left of it at the end and then add "ay". Also the word may be in caps so "AY" may be used in place of "ay"

@AkMo3
Copy link

@AkMo3 AkMo3 commented Oct 30, 2020

Also, you need to send to PR to development branch not master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.