The Wayback Machine - https://web.archive.org/web/20210605233309/https://github.com/TheAlgorithms/Java/pull/2175
Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB-HSV conversion #2175

Merged
merged 4 commits into from Apr 24, 2021
Merged

RGB-HSV conversion #2175

merged 4 commits into from Apr 24, 2021

Conversation

@algobytewise
Copy link
Contributor

@algobytewise algobytewise commented Apr 12, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
algobytewise added 3 commits Apr 1, 2021
@algobytewise
readded EulerMethod.java after sync
5ebfb51
@algobytewise
add RgbHsvConversion.java
598810e
@algobytewise
Delete EulerMethod.java
ccc7d19
@algobytewise
Copy link
Contributor Author

@algobytewise algobytewise commented Apr 12, 2021

For the failed prettier-check, see #2149
@algobytewise algobytewise mentioned this pull request Apr 15, 2021
Closed
@yanglbme
yanglbme approved these changes Apr 15, 2021
View changes
@yanglbme
yanglbme requested changes Apr 15, 2021
View changes
Copy link
Member

@yanglbme yanglbme left a comment

Please add package Conversions; to the file
@algobytewise
add package
bf59dad
@algobytewise
Copy link
Contributor Author

@algobytewise algobytewise commented Apr 15, 2021

I've added the line. Thanks for having a look.
@ayaankhan98
ayaankhan98 approved these changes Apr 24, 2021
View changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

LGTM!
@ayaankhan98 ayaankhan98 merged commit b95ba6c into TheAlgorithms:master Apr 24, 2021
3 of 4 checks passed
3 of 4 checks passed
@github-actions
prettier prettier
Details
@github-actions
build
Details
@github-actions
format
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@ayaankhan98 ayaankhan98 linked an issue that may be closed by this pull request Apr 24, 2021
Waiting for reviews of contributions #2185
Closed
@algobytewise algobytewise deleted the algobytewise:HSV-RGB-conversion branch Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme

@ayaankhan98 ayaankhan98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Waiting for reviews of contributions
3 participants
@algobytewise @yanglbme @ayaankhan98