The Wayback Machine - https://web.archive.org/web/20201128032518/https://github.com/dotnet/aspnetcore/issues/28217
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer to detect async void usage in MVC filter usage #28217

Open
davidfowl opened this issue Nov 28, 2020 · 0 comments
Open

Add analyzer to detect async void usage in MVC filter usage #28217

davidfowl opened this issue Nov 28, 2020 · 0 comments

Comments

@davidfowl
Copy link
Contributor

@davidfowl davidfowl commented Nov 28, 2020

People aren't aware that IAsync*Filters exist and instead use the synchronous ones with async void. It's pretty common and the errors you get are bizzare. Make this an error and offer a codefix to change the synchronous filter to an async one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.