The Wayback Machine - https://web.archive.org/web/20210526191906/https://github.com/dotnet/aspnetcore/issues/33051
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue document updates to prevent race conditions #33051

Open
ryanbrandenburg opened this issue May 26, 2021 · 0 comments
Open

Queue document updates to prevent race conditions #33051

ryanbrandenburg opened this issue May 26, 2021 · 0 comments

Comments

@ryanbrandenburg
Copy link
Member

@ryanbrandenburg ryanbrandenburg commented May 26, 2021

Currently we can sometimes get in a state where the C# LS will be operating on a different version of the document than what we expect because there's no synchronization. If we were to create a Queue in the DefaultRazorLanguageServerCustomMessageTarget which prevented requests to be made simultaneously (so that version at the start of request is the same as version at end of request) we could avoid this.

This work would be obviated by the LSP Embedded Language spec re-design, but given the timelines involved might still be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Razor Tooling vNext
  
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant