Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Request limits middleware PoC #32886
Draft
+1,163
−0
Conversation
JunTaoLuo
force-pushed the
johluo/request-limits-middleware
branch
from
7130ee3
to
9d02c46
|
|
||
| namespace RequestLimiterSample | ||
| { | ||
| [RequestLimit(requestPerSecond: 10)] |
davidfowl
May 21, 2021
Contributor
It's unlikely this would ever be hardcoded, I wonder how useful this is as an attribute. Maybe we need it for completeness.
It's unlikely this would ever be hardcoded, I wonder how useful this is as an attribute. Maybe we need it for completeness.
JunTaoLuo
May 21, 2021
Author
Contributor
What do you mean hardcoded? I think it's probably useful to provide a default implementation that takes in common parameters such as "x request per second" since it's super easy to use. Otherwise, requiring the configuration of policies in ConfigureServices and specifying a policy name here may be overly complicated?
What do you mean hardcoded? I think it's probably useful to provide a default implementation that takes in common parameters such as "x request per second" since it's super easy to use. Otherwise, requiring the configuration of policies in ConfigureServices and specifying a policy name here may be overly complicated?
davidfowl
May 21, 2021
Contributor
I mean read from configuration and set based on the environment
I mean read from configuration and set based on the environment
JunTaoLuo
May 21, 2021
Author
Contributor
Ah yes, config driven limits. I haven't implemented that part yet.
Ah yes, config driven limits. I haven't implemented that part yet.
| private readonly long _newResourcePerSecond; | ||
|
|
||
| private Timer _renewTimer; | ||
| // This is racy |
davidfowl
May 21, 2021
Contributor
yes
yes
JunTaoLuo
force-pushed the
johluo/request-limits-middleware
branch
from
41d5bb4
to
52e0b9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TODO: