Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix ResourceManagerStringLocalizerFactory caching #33129
+14
−7
Conversation
The cache key was using reflection which was visible in allocation profiles since it's called for every view that is rendered.
|
|
||
| var assembly = typeInfo.Assembly; | ||
| return _localizerCache.GetOrAdd(resourceSource.AssemblyQualifiedName!, _ => |
sebastienros
May 29, 2021
Author
Member
This could just be Add, worst case it's called more than once, but only on first concurrent requests.
This could just be Add, worst case it's called more than once, but only on first concurrent requests.
src/Localization/Localization/src/ResourceManagerStringLocalizerFactory.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The cache key was using reflection which was visible in allocation profiles since it's called for every view that is rendered.
Before:
After
Allocations