The Wayback Machine - https://web.archive.org/web/20210601205604/https://github.com/dotnet/aspnetcore/issues/33199
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic tokens shouldn't wait on C# document for first response #33199

Open
ryanbrandenburg opened this issue Jun 1, 2021 · 0 comments
Open

Semantic tokens shouldn't wait on C# document for first response #33199

ryanbrandenburg opened this issue Jun 1, 2021 · 0 comments

Comments

@ryanbrandenburg
Copy link
Member

@ryanbrandenburg ryanbrandenburg commented Jun 1, 2021

We think that waiting for the C# LSP to be totally ready is a significant cause of delays in waiting for Razor Semantic Tokens responses (code here). One solution is to not wait on the C# response, but we have to be careful that:

  1. We still give the C# endpoint a way to tell us we're out of sync.
  2. When new C# tokens are ready we automatically update the tokens.

2 might be a big problem here.

CC @NTaylorMullen who I talked about this with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Razor Tooling vNext
  
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant