The Wayback Machine - https://web.archive.org/web/20201016232318/https://github.com/vuejs/eslint-plugin-vue/pull/1206
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores: Add JSDoc type checking with TypeScript #1206

Merged
merged 4 commits into from Jun 12, 2020
Merged

Chores: Add JSDoc type checking with TypeScript #1206

merged 4 commits into from Jun 12, 2020

Conversation

@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jun 11, 2020

This PR adds JSDoc and TypeScript types to enable type checking.

I also did some refactoring to make the types work better.

@ota-meshi ota-meshi self-assigned this Jun 11, 2020
ota-meshi added 3 commits Jun 12, 2020
@ota-meshi ota-meshi merged commit b33c708 into master Jun 12, 2020
10 checks passed
10 checks passed
Header rules No header rules processed
Details
Pages changed 169 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node-v10 Your tests passed on CircleCI!
Details
ci/circleci: node-v12 Your tests passed on CircleCI!
Details
ci/circleci: node-v14 Your tests passed on CircleCI!
Details
ci/circleci: node-v8 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@ota-meshi ota-meshi deleted the types branch Jun 12, 2020
"VAttribute[directive=false][key.name='is']"(node) {
if (!node.value) {

This comment has been minimized.

@ota-meshi

ota-meshi Jun 26, 2020
Author Member

MEMO: This change fixes the bug reported in #1221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.