The Wayback Machine - https://web.archive.org/web/20201016232317/https://github.com/vuejs/eslint-plugin-vue/pull/128
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove package-lock.json #128

Merged
merged 2 commits into from Aug 4, 2017
Merged

Chore: remove package-lock.json #128

merged 2 commits into from Aug 4, 2017

Conversation

@mysticatea
Copy link
Member

@mysticatea mysticatea commented Aug 4, 2017

This PR removes package-lock.json.

In eslint repo, we have disabled package-lock.json since the following reasons:

  • The lock file does not affect to npm install eslint, but it affects CI builds. This implies that we cannot test with actual dependencies that users install. It reduces the value of CI builds.
  • It sometimes causes merge conflictions.
  • It's fragile.

I propose to remove package-lock.json in this repo as well.

@armano2
Copy link
Collaborator

@armano2 armano2 commented Aug 4, 2017

I had a lot of issues with it to, and we disabled it in all of our projects.

@michalsnik michalsnik merged commit 5d86470 into master Aug 4, 2017
1 check was pending
1 check was pending
ci/circleci Your tests are queued behind your running builds
Details
@michalsnik michalsnik deleted the remove-package-lock branch Aug 4, 2017
filipalacerda pushed a commit to filipalacerda/eslint-plugin-vue that referenced this pull request Aug 5, 2017
* master:
  Add rule `vue/require-valid-default-prop`. (vuejs#119)
  3.10.0
  Update readme to 3.10.0
  Chore: remove package-lock.json (vuejs#128)
  Fix: parserService must exist always (fixes vuejs#125) (vuejs#127)
  Add rule `require-render-return`. (vuejs#114)
  3.9.0
  Update package-lock
  Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113)
  New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95)
  Add namespace check of svg & mathML instead of tag names (vuejs#120)
  ⚠️ Add support for deprecated state in update-rules ⚠️ (vuejs#121)
  Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88)
  Chore: Improve tests for name-property-casing & improve documentation (vuejs#115)
  New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85)
  Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.