The Wayback Machine - https://web.archive.org/web/20210831162014/https://github.com/TheAlgorithms/Python/pull/4317
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mypy): type annotations for linear algebra algorithms #4317

Merged
merged 2 commits into from Apr 5, 2021
Merged

fix(mypy): type annotations for linear algebra algorithms #4317

merged 2 commits into from Apr 5, 2021

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Apr 5, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
dhruvmanila added 2 commits Apr 5, 2021
@dhruvmanila
fix(mypy): type annotations for linear algebra algorithms
ed51e41
@dhruvmanila
refactor: remove linear algebra directory from mypy exclude
d7a0620
@dhruvmanila dhruvmanila requested a review from cclauss as a code owner Apr 5, 2021
@cclauss
cclauss approved these changes Apr 5, 2021
View changes
@cclauss cclauss merged commit 8c29860 into TheAlgorithms:master Apr 5, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
@dhruvmanila dhruvmanila deleted the dhruvmanila:fix-mypy-linear-algebra branch Apr 5, 2021
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
fix(mypy): type annotations for linear algebra algorithms (TheAlgorit…
9c7b35d 
…hms#4317)

* fix(mypy): type annotations for linear algebra algorithms

* refactor: remove linear algebra directory from mypy exclude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dhruvmanila @cclauss