The Wayback Machine - https://web.archive.org/web/20210515083846/https://github.com/TheAlgorithms/Python/pull/4357
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Discord badge in README.md #4357

Merged
merged 2 commits into from Apr 26, 2021
Merged

feat: Add Discord badge in README.md #4357

merged 2 commits into from Apr 26, 2021

Conversation

@Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Apr 25, 2021

Describe your change:

  • Add Discord badge in README.md.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
README.md Outdated Show resolved Hide resolved
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Apr 26, 2021

Hmm, weird. No idea why the checks are failing. Although, it is unrelated to the changes made in this PR.

@dhruvmanila dhruvmanila merged commit 2ce6be0 into master Apr 26, 2021
3 of 5 checks passed
3 of 5 checks passed
@github-actions
pre-commit
Details
@github-actions
pre-commit
Details
@github-actions
build
Details
@github-actions
build
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@Panquesito7 Panquesito7 deleted the add_discord_badge branch Apr 26, 2021
Panquesito7 added a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* feat: Add Discord badge in `README.md`

* Update README.md

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants