[8.x] Adds a small fix for unicode with blade echo handlers #37697
+8
−1
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Howdy!
I noticed when working with blade echo handlers today that when outputting string values (such as unicode characters) that include ';', an error would be thrown. This PR fixes this issue by checking that the value really ends with ';' before stripping it.
I've added a test to prove it works correctly now.
As always, thanks for everything!
Regards,
Luke