The Wayback Machine - https://web.archive.org/web/20220427135146/https://github.com/cuberite/cuberite/pull/5120
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Shulker box #5120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds Shulker box #5120

wants to merge 1 commit into from

Conversation

dImrich
Copy link
Contributor

@dImrich dImrich commented Jan 31, 2021 •
edited

  • Placement
  • Obstruction check
  • UI Window
  • Block entity serialization
  • Item NBT serialization
  • Item Json(Enderchest, Inventory) serialization
  • Lua manual bindings
  • APIDesc
  • #4179 ?

Fixes #4838

@dImrich dImrich force-pushed the ShulkerBox branch 4 times, most recently from d8a1ddc to 7200e93 Compare Feb 6, 2021
@dImrich
Adds Shulker box
9308b3f 
Lua manual bindings and APIDesc
tigerw
tigerw reviewed Feb 6, 2021
View changes
src/Item.h
@@ -200,6 +201,7 @@ class cItem
int m_RepairCost;
cFireworkItem m_FireworkItem;
cColor m_ItemColor;
Json::Value m_BlockEntityTag;
Copy link
Member

@tigerw tigerw Feb 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a decision https://forum.cuberite.org/thread-3325-lastpost.html to add proper Item tag support to cItem, once that's done we can rebase this PR on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigerw tigerw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Shulker Box
2 participants
@dImrich @tigerw