The Wayback Machine - https://web.archive.org/web/20220226044203/https://github.com/microsoft/TypeScript/pull/44599
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose text property of SourceFileLike for some Public APIs #44599

Merged
merged 2 commits into from Feb 25, 2022

Conversation

@cubenoy22
Copy link
Contributor

@cubenoy22 cubenoy22 commented Jun 15, 2021

Fixes #44250

This change makes two APIs available like this: Playground

@microsoft-cla
Copy link

@microsoft-cla microsoft-cla bot commented Jun 15, 2021

CLA assistant check
All CLA requirements met.

@cubenoy22 cubenoy22 force-pushed the expose-sourcefilelike-member branch from d072813 to cae9265 Jun 15, 2021
@sandersn sandersn added this to Not started in PR Backlog Jul 2, 2021
@sandersn sandersn requested review from sandersn and orta Jul 2, 2021
@sandersn sandersn assigned sandersn and orta and unassigned sandersn Jul 2, 2021
@sandersn
Copy link
Member

@sandersn sandersn commented Jul 2, 2021

I still don't think I understand the original request, so that's my first task here.

@sandersn sandersn moved this from Not started to Needs review in PR Backlog Jul 2, 2021
@sandersn sandersn removed the request for review from orta Feb 25, 2022
@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 25, 2022

The TypeScript team hasn't accepted the linked issue #44250. If you can get it accepted, this PR will have a better chance of being reviewed.

@sandersn sandersn assigned sandersn and unassigned orta Feb 25, 2022
@sandersn sandersn requested a review from gabritto Feb 25, 2022
PR Backlog automation moved this from Waiting on reviewers to Needs merge Feb 25, 2022
@sandersn sandersn merged commit 0043abe into microsoft:main Feb 25, 2022
9 checks passed
PR Backlog automation moved this from Needs merge to Done Feb 25, 2022
@cubenoy22 cubenoy22 deleted the expose-sourcefilelike-member branch Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Backlog
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants