hey, can i have this issue?
I'm quite new to this so I might need some guidance

Posting for reference the LGTM alerts: https://lgtm.com/projects/g/numpy/numpy/alerts/?mode=list

I can take a look at the errors in arithmetic.h, which were added during our SIMD division change.

@ganesh-k13 so i just need to fix the errors/warnings shown in the lgtm page ?

I'm quite new to this so I might need some guidance

Welcome.

Please read the developer's workflow guide, especially around commit messages.

Some of those errors/warnings will be difficult to fix since LGTM's ideas may not agree with ours. Try to group the fixes in some logical way: for instance, all the unused imports in one PR and in another PR all the integer overflow warnings.

@mattip thanks.

I've removed all of the unused imports only to find out it breaks the code fsr(hoping you'll tell why), but reading the exceptions and restoring the removed imports solved the issue.
I've restored the following imports -

• _get_ndarray_c_version
• Extension

I can now build and run tests. The test results are same after removing unused imports as linked below.

Before fixing imports -

After fixing imports -

Do you want me to go ahead and do a pr ?

@mattip do you want me to go ahead and do a pr man? or is there I should be doing first ?

Thanks

A cleanup PR would be welcome. Please be sure it only changes the lines you intend to change: sometimes coding tools can "clean up" formatting which makes PRs harder to review.

@charris I've raised a new PR for unused variables. Can anyone check and give a suitable review?

Usually review requires a few days. If after a week no-one has reviewed, feel free to ping (without names) in the PR with a "please review" comment.

thanks, noted.