The Wayback Machine - https://web.archive.org/web/20220321085640/https://github.com/angular/angular/pull/38931
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated support for IE 9, 10, and IE mobile #38931

Closed

Conversation

AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Sep 21, 2020

This PR contains a few commits to remove deprecated support for IE 9, 10, and IE mobile from docs and CI.
Additional code cleanup to remove the code specific to IE 9/10 will happen in followup PRs.

Does this PR introduce a breaking change?

  • Yes
  • No

Angular framework stops IE 9, 10, and IE mobile support.

In v10, framework support for IE 9, 10, and IE mobile was deprecated. In v11 we remove support
for these browsers.

This commit updates angular.io docs to exclude references to IE 9, 10, and IE mobile as well as
polyfills that were needed to run Angular-based apps in these browsers.
This commit removes IE 9 and IE 10 from the browser configuration that is used by CI, so tests
would no longer be executed in these browsers.
This commit removes polyfills that were needed to run tests on IE 9 and IE 10.

BREAKING CHANGE:

In v10, IE 9, 10, and IE mobile support was deprecated. In v11, Angular framework removes IE 9,
10, and IE mobile support completely.
Supporting outdated browsers like these increases bundle size, code complexity, and test load,
and also requires time and effort that could be spent on improvements to the framework.
For example, fixing issues can be more difficult, as a straightforward fix for modern browsers
could break old ones that have quirks due to not receiving updates from vendors.
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 22, 2020

@AndrewKushnir AndrewKushnir marked this pull request as ready for review Sep 22, 2020
@AndrewKushnir AndrewKushnir requested a review from atscott Sep 22, 2020
@pullapprove pullapprove bot requested review from gkalpak and jelbourn Sep 22, 2020
@AndrewKushnir AndrewKushnir requested review from IgorMinar and removed request for gkalpak Sep 22, 2020
Copy link
Contributor

@atscott atscott left a comment

LGTM
// cc @StephenFluin

@AndrewKushnir AndrewKushnir requested a review from StephenFluin Sep 22, 2020
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Reviewed-for: required-docs-approvers

@ngbot ngbot bot added this to the Backlog milestone Sep 22, 2020
@ngbot ngbot bot removed this from the needsTriage milestone Sep 22, 2020
@ngbot ngbot bot added this to the Backlog milestone Sep 22, 2020
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

Reviewed-for: docs-packaging-and-releasing

Copy link
Contributor

@IgorMinar IgorMinar left a comment

looks great! thank you

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Reviewed-for: docs-packaging-and-releasing

alxhub added a commit that referenced this issue Sep 25, 2020
This commit removes IE 9 and IE 10 from the browser configuration that is used by CI, so tests
would no longer be executed in these browsers.

PR Close #38931
alxhub added a commit that referenced this issue Sep 25, 2020
…#38931)

This commit removes polyfills that were needed to run tests on IE 9 and IE 10.

BREAKING CHANGE:

In v10, IE 9, 10, and IE mobile support was deprecated. In v11, Angular framework removes IE 9,
10, and IE mobile support completely.
Supporting outdated browsers like these increases bundle size, code complexity, and test load,
and also requires time and effort that could be spent on improvements to the framework.
For example, fixing issues can be more difficult, as a straightforward fix for modern browsers
could break old ones that have quirks due to not receiving updates from vendors.

PR Close #38931
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Oct 26, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.