Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShared stream WIP #1328
Shared stream WIP #1328
Conversation
|
Has there been any additional progress on this recently? I happen to be looking for this exact feature. |
|
I haven't done anything more with this. I would like some feedback on my approach before I put more effort into polishing it. |
|
@cramertj, @MajorBreakfast any thoughts on this? |
|
Is this PR still being worked on? I ran into several more cases over the past two years where this API could be useful. I'm willing to take over this PR and help drive it to completion if the original author is away. @cramertj, any thoughts on this? |
|
I'm still around. It's been a while since I looked at this, but I was waiting on feedback from the maintainers. |
|
Looks like the shared |
|
Sure thing, @tmccombs! I'll write a few, perhaps based on the tests for |
tmccombs commentedNov 13, 2018
This is similar to #1217 but uses an underlying boxed slice to buffer items, and as a side-effect has a finite buffer size.
This is a work in progress. I'd still like to add some more rigorous unit tests, but I'd like feedback on my general approach, and have other eyes check my logic.