Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `IntoAsyncRead::into_inner()` method and test #1997
Conversation
|
This build failure is pretty puzzling to me, as I cannot duplicate it even with the exact same nightly compiler on Ubuntu 18.04: https://travis-ci.com/rust-lang/futures-rs/jobs/264248283 |
acfoltzer
force-pushed the
acfoltzer:acf/into-async-read-into-inner
branch
from
8600adf
to
100594a
|
Hey, sorry for the delay! I don't quite have the time to properly review this right now, but I'll be sure to take a look in the next few days. |
|
All existing |
acfoltzer commentedDec 6, 2019
•
edited
This is useful when you don't necessarily want to consume the entire stream as a reader, but still want to retain the stream for other uses.
The nested tuple/For readability of code that calls this method, I added an enum.Option/tuple is a bit awkward, but minimal. Do you think it'd be worth making a single-purpose enum to return here instead?