Add a basic dev container #42041
Merged
Add a basic dev container #42041
Conversation
Adds a basic dev container. This basic development environment has tools like gulp installed
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
CONTRIBUTING.md
Outdated
| This repository includes a [development container](https://code.visualstudio.com/docs/remote/containers) that you can use to quickly create an isolated development environment with all the tools you need to start working on TypeScript. To get started with a dev container and VS Code, either: | ||
|
|
||
| - Clone the TypeScript repository locally and use the `Open Folder in Container` command. | ||
| - Use the `Clone Repository in Container Volume` command to clone the TypeScript repository into a new container. |
DanielRosenwasser
Dec 18, 2020
Member
Should this one go first? Sounds like it's probably more ideal for most users, but I don't know much about containers.
Should this one go first? Sounds like it's probably more ideal for most users, but I don't know much about containers.
mjbvz
Dec 18, 2020
Author
Contributor
Sounds good to me. Dev containers definitely make things easy once you have VS Code and docker setup, and with Codespaces you can just connect and the container will automatically be setup for you
Sounds good to me. Dev containers definitely make things easy once you have VS Code and docker setup, and with Codespaces you can just connect and the container will automatically be setup for you
.devcontainer/devcontainer.json
Outdated
| "dbaeumer.vscode-eslint" | ||
| ], | ||
| "remoteUser": "node" | ||
| } |
DanielRosenwasser
Jan 4, 2021
Member
Just for the sake of consistency, we do use spaces over tabs in the repo. Could you swap these over to spaces?
Just for the sake of consistency, we do use spaces over tabs in the repo. Could you swap these over to spaces?
|
Looking at the dockerfile, I think I'd like us to use Volta instead of nvm in the future, but it's not a blocker. |
DanielRosenwasser
merged commit 51c73a1
into
microsoft:master
10 checks passed
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adds a basic dev container. This basic development environment has tools like gulp installed and should make it easier to get started contributing to TS. The dev container also will be picked for codespaces
Fixes #42042