The Wayback Machine - https://web.archive.org/web/20210721152003/https://github.com/microsoft/TypeScript/pull/44801
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types in the boolean trivial lint rule #44801

Merged
merged 1 commit into from Jun 29, 2021
Merged

Conversation

@orta
Copy link
Member

@orta orta commented Jun 29, 2021

Main is currently broken, typescript-eslint stopped exporting the type CallExpressionArgument. A quick look in the typescript-eslint codebase shows it existing in a different package.

However, when I looked at how we used it, we weren't using anything which isn't defined on the base class of Node - so I switched it to that rather than digging into another module for the type.

@orta orta force-pushed the orta:fix_lint_rule branch from 15faa0f to 33e935a Jun 29, 2021
@orta orta requested a review from sandersn Jun 29, 2021
@orta
Copy link
Member Author

@orta orta commented Jun 29, 2021

assigned Nathan as he's usually the first American up and around :P

@sandersn sandersn merged commit fdc31ba into microsoft:main Jun 29, 2021
9 checks passed
9 checks passed
@github-actions
build (10.x)
Details
@github-actions
CodeQL-Build
Details
@github-actions
build (12.x)
Details
@github-actions
build (14.x)
Details
@github-code-scanning
CodeQL 1 analysis not found
Details
@microsoft-cla
license/cla All CLA requirements met.
@azure-pipelines
node10 Build #105888 succeeded
Details
@azure-pipelines
node12 Build #105886 succeeded
Details
@azure-pipelines
node14 Build #105887 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants