The Wayback Machine - https://web.archive.org/web/20211108043642/https://github.com/pytorch/pytorch/pull/60473
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First step to rearrange files in tools folder #60473

Closed
wants to merge 4 commits into from
Closed

First step to rearrange files in tools folder #60473

wants to merge 4 commits into from

Conversation

Reviewers

@seemethere seemethere

@samestep samestep

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@walterddr @facebook-github-bot @seemethere @samestep
@walterddr
Copy link
Contributor

@walterddr walterddr commented Jun 22, 2021 •
edited
Loading

Changes including:

  • introduced linter/, testing/, stats/ folders in tools/
  • move appropriate scripts into these folders
  • change grepped references in the pytorch/pytorch repo

Next step

  • introduce build/ folder for build scripts
  • moves .circleci/scripts and .jenkins/scripts that are not platform dependent to tools/

Test Plan

  • CI (this is important b/c pytorch/test-infra also rely on some script reference, see: pytorch/test-infra#44
  • Aded tools/tests/
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 22, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit cc62ebb (more details on the Dr. CI page and at hud.pytorch.org/pr/60473):

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Loading

@walterddr walterddr mentioned this pull request Jun 22, 2021
Closed
@walterddr walterddr changed the title First step torearrange files in tools folder First step to rearrange files in tools folder Jun 22, 2021
@walterddr walterddr force-pushed the be_rearrange_tools_folder_test branch 2 times, most recently from da62675 to c280214 Jun 23, 2021
@walterddr walterddr force-pushed the be_rearrange_tools_folder_test branch from c280214 to 3212f10 Jun 23, 2021
@walterddr walterddr mentioned this pull request Jun 23, 2021
Merged
walterddr
walterddr reviewed Jun 23, 2021
View changes
mypy.ini Outdated Show resolved Hide resolved
Loading
tools/test/test_test_selection.py Outdated Show resolved Hide resolved
Loading
@walterddr walterddr force-pushed the be_rearrange_tools_folder_test branch from fb61044 to df30da1 Jun 23, 2021
@codecov
Copy link

@codecov codecov bot commented Jun 24, 2021 •
edited
Loading

Codecov Report

Merging #60473 (3e14728) into master (001ff3a) will decrease coverage by 4.75%.
The diff coverage is 89.34%.

❗ Current head 3e14728 differs from pull request most recent head cc62ebb. Consider uploading reports for the commit cc62ebb to get more accurate results

@@            Coverage Diff             @@
##           master   #60473      +/-   ##
==========================================
- Coverage   80.60%   75.84%   -4.76%     
==========================================
  Files        1879     2058     +179     
  Lines      202892   207733    +4841     
==========================================
- Hits       163543   157562    -5981     
- Misses      39349    50171   +10822

Loading

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 24, 2021

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

Rong Rong added 4 commits Jun 24, 2021
initial commit to rearrange tools folder
b55da9e
fix mypy
093a28d
fix flake8
bbe1f80
modify git-clang-format permission
cc62ebb
@walterddr walterddr force-pushed the be_rearrange_tools_folder_test branch from 3e14728 to cc62ebb Jun 24, 2021
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 24, 2021

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

1 similar comment
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 24, 2021

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 24, 2021

@walterddr merged this pull request in 7e619b9.

Loading

samestep
samestep approved these changes Jun 24, 2021
View changes
Copy link
Contributor

@samestep samestep left a comment

looks good, thank you! just a few cosmetic comments about tools/README.md and about imports (see #60119)

Loading

tools/stats/print_test_stats.py
from tools.stats.s3_stat_parser import (newify_case, get_S3_object_from_bucket, get_test_stats_summaries_for_job,
Report, Status, Commit, HAVE_BOTO3, Version2Case, VersionedReport,
Version1Report, Version2Report, ReportMetaMeta)
Copy link
Contributor

@samestep samestep Jun 24, 2021

Suggested change
from tools.stats.s3_stat_parser import (newify_case, get_S3_object_from_bucket, get_test_stats_summaries_for_job,
Report, Status, Commit, HAVE_BOTO3, Version2Case, VersionedReport,
Version1Report, Version2Report, ReportMetaMeta)
from tools.stats.s3_stat_parser import (
HAVE_BOTO3,
Commit,
Report,
ReportMetaMeta,
Status,
Version1Report,
Version2Case,
Version2Report,
VersionedReport,
get_S3_object_from_bucket,
get_test_stats_summaries_for_job,
newify_case,
)

Loading

tools/stats/test_history.py
from tools.stats.s3_stat_parser import (Report, get_cases,
get_test_stats_summaries)
Copy link
Contributor

@samestep samestep Jun 24, 2021

Suggested change
from tools.stats.s3_stat_parser import (Report, get_cases,
get_test_stats_summaries)
from tools.stats.s3_stat_parser import (
Report,
get_cases,
get_test_stats_summaries,
)

Loading

tools/test/test_stats.py
from tools.stats.s3_stat_parser import (Commit, Report, ReportMetaMeta,
Status, Version1Case,
Version1Report, Version2Case,
Version2Report)
Copy link
Contributor

@samestep samestep Jun 24, 2021

Suggested change
from tools.stats.s3_stat_parser import (Commit, Report, ReportMetaMeta,
Status, Version1Case,
Version1Report, Version2Case,
Version2Report)
from tools.stats.s3_stat_parser import (
Commit,
Report,
ReportMetaMeta,
Status,
Version1Case,
Version1Report,
Version2Case,
Version2Report,
)

Loading

tools/README.md
stdin, print names of nonempty files whose contents don't end in exactly one
trailing newline, exit with status 1 if no output printed or 0 if some
filenames were printed.
* [translate_annotations.py](translate_annotations.py) - Read [Flake8][] or
* [linter/translate_annotations.py](linter/translate_annotations.py) - Read [Flake8][] or
Copy link
Contributor

@samestep samestep Jun 24, 2021

for consistency, the things that are now under linter/ or stats/ should be in sub-bullets (similar to shared/, fast_nvcc/, and amd_build/)

Loading

@ZolotukhinM ZolotukhinM mentioned this pull request Jun 25, 2021
Closed
ZolotukhinM added a commit that referenced this issue Jun 25, 2021
@ZolotukhinM
[Tools] Update path in clang_format_utils after #60473
c44d7da 
PR #60473 introduced a new folders nesting level, this change updates
clang_format_utils.py to accordingly adjust the way it sets up root
path.

[ghstack-poisoned]
ZolotukhinM added a commit that referenced this issue Jun 25, 2021
@ZolotukhinM
[Tools] Update path in clang_format_utils after #60473
4c19bc7 
PR #60473 introduced a new folders nesting level, this change updates
clang_format_utils.py to accordingly adjust the way it sets up root
path.

ghstack-source-id: 935dfab02e0f275f7537531afa967f70aeae100f
Pull Request resolved: #60782
facebook-github-bot added a commit that referenced this issue Jun 25, 2021
@ZolotukhinM @facebook-github-bot
[Tools] Update path in clang_format_utils after #60473 (#60782)
7188d84 
Summary:
Pull Request resolved: #60782

PR #60473 introduced a new folders nesting level, this change updates
clang_format_utils.py to accordingly adjust the way it sets up root
path.

Test Plan: Imported from OSS

Reviewed By: zhxchen17

Differential Revision: D29403622

Pulled By: ZolotukhinM

fbshipit-source-id: 6404271615c2d263834cf538ab0153c4d41cc5c3
asuhan added a commit to asuhan/pytorch that referenced this issue Jun 28, 2021
@ZolotukhinM @asuhan
[Tools] Update path in clang_format_utils after pytorch#60473 (pytorc…
9640b39 
…h#60782)

Summary:
Pull Request resolved: pytorch#60782

PR pytorch#60473 introduced a new folders nesting level, this change updates
clang_format_utils.py to accordingly adjust the way it sets up root
path.

Test Plan: Imported from OSS

Reviewed By: zhxchen17

Differential Revision: D29403622

Pulled By: ZolotukhinM

fbshipit-source-id: 6404271615c2d263834cf538ab0153c4d41cc5c3
asuhan added a commit that referenced this issue Jun 30, 2021
@ZolotukhinM @asuhan
[Tools] Update path in clang_format_utils after #60473 (#60782)
0a208a4 
Summary:
Pull Request resolved: #60782

PR #60473 introduced a new folders nesting level, this change updates
clang_format_utils.py to accordingly adjust the way it sets up root
path.

Test Plan: Imported from OSS

Reviewed By: zhxchen17

Differential Revision: D29403622

Pulled By: ZolotukhinM

fbshipit-source-id: 6404271615c2d263834cf538ab0153c4d41cc5c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment