The Wayback Machine - https://web.archive.org/web/20200907052438/https://github.com/emacs-evil/evil/pull/1127/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-w support yank word when search-module is 'evil-search #1127

Open
wants to merge 2 commits into
base: master
from

Conversation

@jixiuf
Copy link
Contributor

jixiuf commented Feb 12, 2019

No description provided.

@edkolev
Copy link
Member

edkolev commented Feb 13, 2019

Could you describe what behaviour this is trying to achieve? C-w deletes the previous work in the search prompt in vim.

@jixiuf
Copy link
Contributor Author

jixiuf commented Feb 14, 2019

same to C-w in isearch, search words under point ,and you can press C-w multiple times

@nnicandro
Copy link
Contributor

nnicandro commented Feb 22, 2019

Yes, actually C-w should have the opposite behavior. It should delete the previous word in the Ex minibuffer since that is how vim does it. That is more in line with how evil is meant to behave anyways since its main goal is to emulate vi/vim.

But there are variables like evil-want-C-u-scroll which take into account discrepancies between fundamental keys used in both Emacs and Vim but have different meaning. Perhaps this could be another one of those cases and we could have an
evil-want-C-w-delete-in-search variable or just piggyback off of evil-want-C-w-delete? I'm thinking the latter makes more sense since if someone is already used to the Emacs way of C-w meaning to kill text, they wouldn't want that behavior to be different in Ex/search. If this is done then it would probably make sense for evil-ex-completion-map to also obey evil-want-C-w-delete.

@jixiuf jixiuf force-pushed the jixiuf:master branch 2 times, most recently from ae9c216 to e156527 Feb 25, 2019
@jixiuf jixiuf force-pushed the jixiuf:master branch from e156527 to bc72e2d Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.