The Wayback Machine - https://web.archive.org/web/20200907052443/https://github.com/emacs-evil/evil/pull/1209/
Skip to content

/ evil

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing call-interactively evil-scroll-up test #1209

Draft
wants to merge 5 commits into
base: master
from
Draft

add failing call-interactively evil-scroll-up test #1209

wants to merge 5 commits into from

Conversation

@codygman
Copy link

codygman commented Nov 28, 2019 •
edited

See #1208

$ git status
On branch repro-interactive-evil-scroll-up-failure-with-make-test
nothing to commit, working tree clean

$ git log --oneline -n1
df4b9f3 (HEAD -> repro-interactive-evil-scroll-up-failure-with-make-test, origin/repro-interactive-evil-scroll-up-failure-with-make-test) add failing evil-scroll-up test

$ make test            
emacs -nw -Q -L . -L lib -l evil-tests.el \
--eval "(evil-tests-initialize '() '())"
make: *** [Makefile:58: test] Error 1

$ cat test-results.txt 
Selector: t
Passed:  190
Failed:  1 (1 unexpected)
Skipped: 2
Total:   193/193

Started at:   2019-11-28 15:13:49-0600
Finished.
Finished at:  2019-11-28 15:14:00-0600

F........................................................................s............................s..........................................................................................

F evil-scroll-up-should-move-point-as-expected
    (wrong-type-argument fixnump nil)


Selector: t
Passed:  190
Failed:  1 (1 unexpected)
Skipped: 2
Total:   193/193

Started at:   2019-11-28 15:18:00-0600
Finished.
Finished at:  2019-11-28 15:18:11-0600

F........................................................................s............................s..........................................................................................

F evil-scroll-up-should-move-point-as-expected
    (wrong-type-argument fixnump nil)
codygman added 2 commits Nov 28, 2019
@codygman
add failing evil-scroll-up test
Loading status checks…
df4b9f3
@codygman
trace evil-scroll-up and see what's returned
Loading status checks…
063f8d3
@codygman
Copy link
Author

codygman commented Nov 28, 2019

After 063f8d3 which adds tracing to evil-scroll-up I get:

[cody@nixos:~/bsab/data/dd/0930cf-16e2-47bc-9ebf-3ca6e53d3c2d/evil]$ make test
emacs -nw -Q -L . -L lib -l evil-tests.el \
--eval "(evil-tests-initialize '() '())"
^[[Omake: *** [Makefile:58: test] Error 1

[cody@nixos:~/bsab/data/dd/0930cf-16e2-47bc-9ebf-3ca6e53d3c2d/evil]$ cat *results.txt
Selector: t
Passed:  190
Failed:  1 (1 unexpected)
Skipped: 2
Total:   193/193

Started at:   2019-11-28 15:33:30-0600
Finished.
Finished at:  2019-11-28 15:33:41-0600

F........................................................................s............................s..........................................................................................

F evil-scroll-up-should-move-point-as-expected
    (wrong-type-argument fixnump nil)


======================================================================
1 -> (evil-scroll-up nil)
1 <- evil-scroll-up: !non-local\ exit!
codygman added 3 commits Nov 28, 2019
@codygman
cat out trace-evil-scroll-up-results.txt in CI
Loading status checks…
9b93d59
@codygman
show that fixnum error goes away on 2nd run of evil-scroll-up test
297224e
@codygman
change expected point of evil scroll up
Loading status checks…
2c392da 
this confirms that subsequent runs of ert tests interactively seem to
fix the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@codygman
You can’t perform that action at this time.