Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix bugs in evil-with-undo' and evil-undo-pop' with undo-tree.
#1430
+37
−33
Conversation
Addresses #1074 - evil-with-undo: nconc'ing onto front of buffer-undo-list here can corrupt buffer-undo-list when in undo-tree-mode in rare circumstances (see issue #1074). Leave standard undo machinery to work as usual when undo is enabled. Deal with disabled undo by temporarily enabling then disabling undo, and transferring any undo changes to evil-temporary-undo. - evil-undo-pop: This function called `undo' directly from Elisp, which is wrong when in undo-tree-mode. Fix this by calling undo-tree-undo instead when in undo-tree-mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Addresses #1074
evil-with-undo:
nconc'ing onto front of buffer-undo-list here can corrupt buffer-undo-list
when in undo-tree-mode in rare circumstances (see issue #1074). Leave
standard undo machinery to work as usual when undo is enabled. Deal with
disabled undo by temporarily enabling then disabling undo, and transferring
any undo changes to evil-temporary-undo.
evil-undo-pop:
This function called `undo' directly from Elisp, which is wrong when in
undo-tree-mode. Fix this by calling undo-tree-undo instead when in
undo-tree-mode.