The Wayback Machine - https://web.archive.org/web/20210714080512/https://github.com/chartjs/Chart.js/pull/9364
Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout: support box stacking #9364

Merged
merged 5 commits into from Jul 11, 2021
Merged

Layout: support box stacking #9364

merged 5 commits into from Jul 11, 2021
+283 −42

Conversation

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Jul 6, 2021 •
edited

Closes #5895

image
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Jul 6, 2021 •
edited

Filename Size Change
dist/chart.esm.js 71.7 kB +419 B (+1%)
dist/chart.js 90.8 kB +445 B (0%)
dist/chart.min.js 64.7 kB +276 B (0%)
@etimberg
etimberg reviewed Jul 6, 2021
View changes
Copy link
Member

@etimberg etimberg left a comment

Makes sense to me. Might be worth a sample as well
@kurkle kurkle marked this pull request as ready for review Jul 8, 2021
@etimberg
etimberg reviewed Jul 8, 2021
View changes
Copy link
Member

@etimberg etimberg left a comment

One minor comment
src/core/core.layouts.js Outdated Show resolved Hide resolved
@etimberg
etimberg reviewed Jul 9, 2021
View changes
@etimberg
etimberg reviewed Jul 9, 2021
View changes
@etimberg etimberg added this to the Version 3.5.0 milestone Jul 10, 2021
@etimberg
Copy link
Member

@etimberg etimberg commented Jul 10, 2021

The CI should be fixed via a rebase
kurkle added 5 commits Jul 6, 2021
@kurkle
Layout: support box stacking
93d771a
@kurkle
Add stackWeight and sample
330b62b
@kurkle
Cleanup, update docs and types
f634965
@kurkle
Avoid div0
d24c0d6
@kurkle
missing semi
e31272b
@kurkle kurkle force-pushed the kurkle:stacked-axes branch from ab2d8d2 to e31272b Jul 10, 2021
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Jul 11, 2021

rebased
@etimberg
etimberg approved these changes Jul 11, 2021
View changes
@etimberg etimberg merged commit 47d4b04 into chartjs:master Jul 11, 2021
9 of 10 checks passed
9 of 10 checks passed
@github-actions
build (ubuntu-latest)
Details
@github-actions
build
Details
@github-actions
build (windows-latest)
Details
@github-actions
finish
Details
codeclimate 3 issues to fix
Details
Coveralls - ubuntu-latest-chrome First build on stacked-axes at 96.749%
Details
Coveralls - ubuntu-latest-firefox First build on stacked-axes at 96.652%
Details
Coveralls - windows-latest-chrome First build on stacked-axes at 96.749%
Details
Coveralls - windows-latest-firefox First build on stacked-axes at 96.652%
Details
coverage/coveralls First build on stacked-axes at 96.749%
Details
@kurkle kurkle deleted the kurkle:stacked-axes branch Jul 11, 2021
sthagen added a commit to sthagen/Chart.js that referenced this pull request Jul 11, 2021
@sthagen
Merge pull request #180 from chartjs/master
d034c42 
Layout: support box stacking (chartjs#9364)
@PavolSvidran PavolSvidran mentioned this pull request Jul 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 3.5.0
Linked issues

Successfully merging this pull request may close these issues.

[FEATURE] Stacked up axes
2 participants
@kurkle @etimberg