The Wayback Machine - https://web.archive.org/web/20210710183323/https://github.com/apache/hadoop/pull/2244
Skip to content

/ hadoop

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARN-10407. Add phantomjsdriver.log to gitignore. #2244

Merged
merged 1 commit into from Sep 1, 2020
Merged

YARN-10407. Add phantomjsdriver.log to gitignore. #2244

merged 1 commit into from Sep 1, 2020

Conversation

@tasanuma
Copy link
Member

@tasanuma tasanuma commented Aug 25, 2020

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
@hadoop-yetus
Copy link

@hadoop-yetus hadoop-yetus commented Aug 25, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 19m 9s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
35m 33s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2244/1/artifact/out/Dockerfile
GITHUB PR #2244
Optional Tests dupname asflicense
uname Linux bc6712caa10c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 82a7505
Max. process+thread count 455 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2244/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.
@jiwq
jiwq reviewed Aug 27, 2020
View changes
Copy link
Member

@jiwq jiwq left a comment

+1 LGTM
@tasanuma
Copy link
Member Author

@tasanuma tasanuma commented Sep 1, 2020

Thanks for your review, @jiwq. But I think I need an approve to merge it.
@tasanuma
YARN-10407. Add phantomjsdriver.log to gitignore.
8417957
@tasanuma tasanuma force-pushed the tasanuma:YARN-10407 branch from adc549a to 8417957 Sep 1, 2020
@tasanuma
Copy link
Member Author

@tasanuma tasanuma commented Sep 1, 2020

Rebased the latest trunk.
@aajisaka
Copy link
Member

@aajisaka aajisaka commented Sep 1, 2020

+1
I'd like to change the log dir to target/, however, it seems that there is no available option to change the log dir via pom.xml.
@aajisaka aajisaka self-requested a review Sep 1, 2020
@aajisaka
aajisaka approved these changes Sep 1, 2020
View changes
@tasanuma
Copy link
Member Author

@tasanuma tasanuma commented Sep 1, 2020

Thanks for your review, @aajisaka!
@tasanuma tasanuma merged commit 658b1a6 into apache:trunk Sep 1, 2020
@tasanuma tasanuma deleted the tasanuma:YARN-10407 branch Sep 1, 2020
@hadoop-yetus
Copy link

@hadoop-yetus hadoop-yetus commented Sep 1, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 21m 52s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ asflicense 0m 30s The patch generated 3 ASF License warnings.
40m 51s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2244/2/artifact/out/Dockerfile
GITHUB PR #2244
Optional Tests dupname asflicense
uname Linux b6529448df62 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 4ffe26f
asflicense https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2244/2/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 307 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2244/2/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.
aajisaka added a commit that referenced this pull request Feb 17, 2021
@tasanuma @aajisaka
YARN-10407. Add phantomjsdriver.log to gitignore. (#2244)
73f9083 
(cherry picked from commit 658b1a6)

 Conflicts:
	.gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwq jiwq

@aajisaka aajisaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tasanuma @hadoop-yetus @aajisaka @jiwq