The Wayback Machine - https://web.archive.org/web/20210710183104/https://github.com/apache/hadoop/pull/2703
Skip to content

/ hadoop

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-17109. add guava BaseEncoding to illegalClasses #2703

Merged
merged 1 commit into from Feb 17, 2021
Merged

HADOOP-17109. add guava BaseEncoding to illegalClasses #2703

merged 1 commit into from Feb 17, 2021

Conversation

@amahussein
Copy link
Contributor

@amahussein amahussein commented Feb 15, 2021

HADOOP-17109: Replace Guava base64Url and base64 with Java8+ base64

The hadoop source code relies on org.apache.commons. for Base64.
This PR is to add the com.google.common.io.BaseEncoding to illegal classes in order to prevent using the guava import in future commits.

  • This PR only touches the checkstyle configuration.
  • There are no occurrences of com.google.common.io.BaseEncoding in the code.
@amahussein
HADOOP-17109. add guava BaseEncoding to illegalClasses
671cf4a
@hadoop-yetus
Copy link

@hadoop-yetus hadoop-yetus commented Feb 15, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 12s trunk passed
+1 💚 compile 0m 20s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 21s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 mvnsite 0m 20s trunk passed
+1 💚 shadedclient 48m 33s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 26s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 24s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
+1 💚 compile 0m 15s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 15s the patch passed
+1 💚 compile 0m 14s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 0m 14s the patch passed
+1 💚 mvnsite 0m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedclient 12m 39s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 19s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
_ Other Tests _
+1 💚 unit 0m 20s hadoop-build-tools in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
68m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2703/1/artifact/out/Dockerfile
GITHUB PR #2703
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux f455a51d93c9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / bad6038
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2703/1/testReport/
Max. process+thread count 537 (vs. ulimit of 5500)
modules C: hadoop-build-tools U: hadoop-build-tools
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2703/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.
@amahussein
Copy link
Contributor Author

@amahussein amahussein commented Feb 16, 2021

Fortunately, guava.baseEncoding is not used in hadoop code. So, I did not have to change source code.
@aajisaka can you please take a look at the checkstyle configuration?
@aajisaka
aajisaka approved these changes Feb 17, 2021
View changes
Copy link
Member

@aajisaka aajisaka left a comment

+1
@aajisaka aajisaka merged commit eac7aef into apache:trunk Feb 17, 2021
1 check failed
1 check failed
@asf-cloudbees-jenkins-ci-hadoop
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@aajisaka
Copy link
Member

@aajisaka aajisaka commented Feb 17, 2021

Thank you @amahussein for your contribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajisaka aajisaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@amahussein @hadoop-yetus @aajisaka