The Wayback Machine - https://web.archive.org/web/20210106151854/https://github.com/ruby-grape/grape/pull/1804
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for failing nested given validation #1804

Open
wants to merge 1 commit into
base: master
from

Conversation

@andreacfm
Copy link
Contributor

@andreacfm andreacfm commented Oct 22, 2018

Using nested given validations looks unsupported. This is just a simple test case to show the issue.

@grape-bot
Copy link

@grape-bot grape-bot commented Oct 22, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1804](https://github.com/ruby-grape/grape/pull/1804): Added test for failing nested given validation - [@andreacfm](https://github.com/andreacfm).

Generated by 🚫 danger

@dblock
Copy link
Member

@dblock dblock commented Oct 31, 2018

@darren987469 was just in this code in #1810, maybe interested in taking a look at this too?

@andreacfm
Copy link
Contributor Author

@andreacfm andreacfm commented Oct 31, 2018

@dblock I will have a look. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.