Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow modification of draft and draftState for "immer" #1917
Conversation
The immer library requires the modification of parameter properties. immerjs/immer#189
| 'ctx', // for Koa routing | ||
| 'req', // for Express requests | ||
| 'request', // for Express requests | ||
| 'res', // for Express responses | ||
| 'response', // for Express responses | ||
| '$scope', // for Angular 1 scopes | ||
| 'draft', // for immer | ||
| 'draftState', // for immer |
This comment has been minimized.
This comment has been minimized.
ljharb
Sep 16, 2018
Collaborator
i don't think we need to add specific exceptions for every mutating pattern, and i'm not yet convinced that immer's pattern of encouraging mutation in code is a beneficial one.
spawnia
commented
Nov 29, 2018
•
|
As @mweststrate summarized quite nicely, this exception is really the only way for the @ljharb i think the popularity of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brummelte commentedSep 15, 2018
The immer library requires the modification of parameter properties.
immerjs/immer#189