Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[guide] [react] add note about deprecated lifecycles #1993
Conversation
|
These are not actually "deprecated" in the sense that they'll only be "unsafe with async rendering". Either way, we should leave these here, and let React itself (and eslint-plugin-react rules) warn on these methods as needed. |
This makes sense. But can we like address developer that this lifecycles are now no more in use like by adding a label in parenthesis or making seperate section for it ? |
|
I think a section for it that calls out that only in React 16.3+, certain methods should be avoided in favor of others, would be useful, yes. |
|
Okay. So should I make changes now in readme file acc. to it? |
|
Updating this PR to do that would be great! |
|
Sure. So should I finally add a section about avoiding lifecycles? |
|
Not avoiding; but using the ones appropriate for your React version. Not everyone is on the latest version. |
| @@ -701,6 +702,15 @@ We don’t recommend using indexes for keys if the order of items may change. | |||
| > Why? [`isMounted` is an anti-pattern][anti-pattern], is not available when using ES6 classes, and is on its way to being officially deprecated. | |||
| [anti-pattern]: https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html | |||
|
|
|||
| ## Things to avoid | |||
This comment has been minimized.
This comment has been minimized.
ljharb
Jan 19, 2019
Collaborator
This isn't the right phrasing here; someone using React 16.2 shouldn't be avoiding anything.
|
|
||
| ## Things to avoid | ||
|
|
||
| Using deprecated APIs will create bad legacy code. Hence it's good to know that which APIs have been deprecated. |
This comment has been minimized.
This comment has been minimized.
ljharb
Jan 19, 2019
Collaborator
All of these APIs are not "bad" or "legacy", they're solely not safe to use with async rendering. Can you rephrase this to have less of a judgemental connotation?
|
|
||
| Using deprecated APIs will create bad legacy code. Hence it's good to know that which APIs have been deprecated. | ||
|
|
||
| These Component lifecycles are been deprecated since React version 16.3+ : |
This comment has been minimized.
This comment has been minimized.
ljharb
Jan 19, 2019
Collaborator
Could we add, for each one, which methods should be used instead (with links to their documentation)?
ljharb
changed the title
meetzaveri commentedJan 16, 2019
There were still deprecated lifecycle being mentioned in two places. Thus by removing them, it will make clear sense of latest React API after 16.2.