The Wayback Machine - https://web.archive.org/web/20210807164813/https://github.com/go-gitea/gitea/pull/12114
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts rework #12114

Merged
merged 3 commits into from Jul 6, 2020
Merged

Fonts rework #12114

merged 3 commits into from Jul 6, 2020

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jul 1, 2020

  • Use system fonts only for text to avoid FOUT
  • Move font-awesome to npm/webpack
  • Move NotoColorEmoji to web_src
  • Remove presumably unneccesary 'PT Sans Narrow'
  • Simplify webpack import exclusions

Fixes: #11818
Fixes: #11814

@@ -125,7 +75,7 @@
.ui.steps .step .title,
.ui.text.container,
.ui.language > .menu > .item& {
font-family: Roboto, @fonts, sans-serif;

This comment has been minimized.

@mrsdizzie

mrsdizzie Jul 1, 2020
Member

Bless 🙏

@mrsdizzie
Copy link
Member

@mrsdizzie mrsdizzie commented Jul 2, 2020

LGTM thanks! I'm also of the opinion that we don't really need to ship a emoji fallback webfont and the few people who run systems that don't install one by default and haven't already installed one should expect to just not see them which must already be true for almost every other site they visit.

Feels like an intentional decision for somebody not to have one of these fonts installed at this point and I can't imagine why they would prefer downloading a 9MB Web font instead of installing a real one system wide. I only agreed to it previously because I didn't want the emoji PR held back but think it is unnecessary for us to provide. Maybe for another PR though

@silverwind
Copy link
Member Author

@silverwind silverwind commented Jul 2, 2020

Yeah I think I tend to agree to remove the emoji fallback but as it stands, it does not hurt us to have. Browsers should only attempt the download if they can't display a certain emoji. Then there's the issue that the font does not work in Firefox because of a bug there, so it's only targeting Chrome/Edge on some Linux distributions really.

- Use system fonts only for text to avoid FOUT
- Move font-awesome to npm/webpack
- Move NotoColorEmoji to web_src
- Remove presumably unneccesary 'PT Sans Narrow'
- Simplify webpack import exclusions

Fixes: #11818
Fixes: #11814
@silverwind silverwind force-pushed the silverwind:nativefonts branch from 07a9d75 to f6ecba5 Jul 2, 2020
@CirnoT
CirnoT approved these changes Jul 4, 2020
Copy link
Member

@CirnoT CirnoT left a comment

Looks good, would appreciate someone with Chinese locale testing it too however

@lafriks lafriks added this to the 1.13.0 milestone Jul 6, 2020
@lafriks
lafriks approved these changes Jul 6, 2020
@silverwind
Copy link
Member Author

@silverwind silverwind commented Jul 6, 2020

would appreciate someone with Chinese locale testing it too however

I did not change anything about the locale-specific font overrides, so I guess those will be fine.

@lafriks lafriks merged commit 62c2c17 into go-gitea:master Jul 6, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@silverwind silverwind deleted the silverwind:nativefonts branch Jul 6, 2020
@lunny
Copy link
Member

@lunny lunny commented Jul 6, 2020

Looks good, would appreciate someone with Chinese locale testing it too however

I will test it after it deployed on try.gitea.io

ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
- Use system fonts only for text to avoid FOUT
- Move font-awesome to npm/webpack
- Move NotoColorEmoji to web_src
- Remove presumably unneccesary 'PT Sans Narrow'
- Simplify webpack import exclusions

Fixes: go-gitea#11818
Fixes: go-gitea#11814

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
successgo added a commit to successopen/gitea that referenced this pull request Aug 20, 2020
- Use system fonts only for text to avoid FOUT
- Move font-awesome to npm/webpack
- Move NotoColorEmoji to web_src
- Remove presumably unneccesary 'PT Sans Narrow'
- Simplify webpack import exclusions

Fixes: go-gitea#11818
Fixes: go-gitea#11814

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

7 participants