The Wayback Machine - https://web.archive.org/web/20201016024738/https://github.com/aalhour/C-Sharp-Algorithms/issues/46
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NetStandard and nuget #46

Open
saad749 opened this issue Sep 22, 2017 · 5 comments · May be fixed by #133
Open

.NetStandard and nuget #46

saad749 opened this issue Sep 22, 2017 · 5 comments · May be fixed by #133
Assignees
Labels

Comments

@saad749
Copy link

@saad749 saad749 commented Sep 22, 2017

Hi,

Are there any plans to migrate this project to .net standard and/or have a nuget package?

@aalhour
Copy link
Owner

@aalhour aalhour commented Oct 16, 2017

Hi @saad749 ,

There are plans but we're not working on them yet. Do you want to submit a PR for it? I'll be more than happy to review and accept it.

Cheers,
Ahmad

@aalhour aalhour added this to To do in Kanban Board Oct 30, 2019
@aalhour aalhour added feature and removed optimization labels Oct 30, 2019
@nickntg nickntg mentioned this issue Nov 1, 2019
@RyanGrange
Copy link
Contributor

@RyanGrange RyanGrange commented Apr 25, 2020

I've got a few changes that move these from netcore2.0 to netstandard2.0 and also updates the nuspec file (adding the dependency for targetFramework .NETStandard2.0). Would it be better to split those up or keep them together since it's the shift from core app to standard library that created the dependency?

@RyanGrange
Copy link
Contributor

@RyanGrange RyanGrange commented Apr 25, 2020

I went ahead and created #133 for review. I hope I'm not being rude by going ahead with this rather than waiting for a reply to my earlier question. The PR makes the move from netcoreapp2.0 to netstandard2.0 and I updated the nuspec with the netstandard dependency. Once this gets into nuget.org C-Sharp-Algorithms would be usable by both netcoreapp2 and up, but also older DotNet Framework applications using 4.6.1 and above according to https://docs.microsoft.com/en-us/dotnet/standard/net-standard

@aalhour aalhour linked a pull request that will close this issue May 27, 2020
8 of 8 tasks complete
@GF-Huang
Copy link

@GF-Huang GF-Huang commented Jul 9, 2020

Progress?

@RyanGrange
Copy link
Contributor

@RyanGrange RyanGrange commented Aug 15, 2020

I saw the issue was assigned to me, and the PR has been reviewed. What else needs to be done to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban Board
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.