The Wayback Machine - https://web.archive.org/web/20250506171613/https://github.com/angular/angular/pull/42663
Skip to content

docs: clarify community feature request voting #42663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: clarify community feature request voting #42663

wants to merge 1 commit into from

Conversation

markgoho
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:
    A small update to the community feature request voting explanation

What is the current behavior?

The current process by which community members vote on feature requests is described, but is missing some important details like where to cast the vote and what votes are counted. Additionally the length of voting is wrong (60 days). The bot allows for 20 days of voting.

Issue Number: N/A

What is the new behavior?

Updated language, fixed voting length.

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from josephperrott June 25, 2021 18:21
@google-cla google-cla bot added the cla: yes label Jun 25, 2021
@ngbot ngbot bot added this to the Backlog milestone Jun 25, 2021
@josephperrott josephperrott requested a review from mgechev June 28, 2021 16:37
josephperrott
josephperrott approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Review-for: dev-infra

@josephperrott josephperrott added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 28, 2021
@josephperrott
Copy link
Member

@mgechev Can we have your review on this PR as well?

mgechev
mgechev reviewed Jun 28, 2021
View reviewed changes
docs/GITHUB_PROCESS.md Outdated
To include the community in the feature request process, we open voting for 60 days. Anyone can cast
a vote for the request with a thumbs-up (👍) reaction. When a feature request reaches 20 or more
upvotes, we formally consider the feature request. Alternatively, the bot closes the request.
To include the community in the feature request process, we open voting for 20 days. Anyone can cast
Copy link
Member

@mgechev mgechev Jun 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only for issues older than 60 days. I think the bot might be skipping newer feature requests (maybe there's a bug). The rule is:

  • If the bot finds a new feature request it gives it 60 days for voting
  • If the bot finds a feature request older than 60 days, it gives it 20 days for voting

mgechev
mgechev requested changes Jun 28, 2021
View reviewed changes
Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest updating to only reflect the 20 day rule for old feature requests. I'll have a look at the logic for new feature requests today and once this works as expected, we can add more details.

@mgechev
Copy link
Member

mgechev commented Jun 30, 2021

I had a look today and it seems like the bot is working as expected.

The way the process works:

  • New feature requests get 60 days period to collect 20 or more 👍 to be added for consideration
  • Old feature requests (created 60+ days ago), get 20 days to collect 20 or more 👍

In the meantime, anyone who can add labels to issues and is familiar with our roadmap can add in backlog label to pause the voting process in case they decide the request is already part of an existing prioritized effort.

@markgoho
Copy link
Contributor Author

markgoho commented Jul 1, 2021

@mgechev updated the docs change to reflect your investigation

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 12, 2021
AndrewKushnir pushed a commit that referenced this pull request Jul 12, 2021
@markgoho @AndrewKushnir
docs: clarify voting phase for feature requests (#42663)
b101ad0 
PR Close #42663
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev mgechev approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@markgoho @josephperrott @mgechev @AndrewKushnir @jessicajaniuk