The Wayback Machine - https://web.archive.org/web/20220322105457/https://github.com/angular/angularfire/pull/2598
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to Angular & CLI 10.1.x and re-run migrations #2598

Merged
merged 1 commit into from Sep 25, 2020

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Sep 25, 2020

Checklist

  • Issue number for this PR: #2526
  • Docs included?: no
  • Test units included?: yes
  • In a clean directory, yarn install, yarn test run successfully? yes

Description

update to Angular & CLI 10.1.x and re-run migrations

  • run v10.1 CLI migrations for lib, sample, and test projects
    • removes Solution style tsconfig
    • updates tslint config
  • pin [email protected] because 0.10.3 causes test failures
  • install or correct missing peerDependencies
  • update a few other dependencies
  • remove references to e2e in sample workspace as there are no e2e tests
  • replace deprecated async() with waitForAsync() in tests
  • add tsconfig.server.json to list of files for linting
  • fix tests prompting to enable Angular CLI analytics

Code sample

N/A

- run v10.1 CLI migrations for lib, sample, and test projects
  - removes Solution style tsconfig
  - updates tslint config
- pin [email protected] because 0.10.3 causes test failures
- install or correct missing peerDependencies
- update a few other dependencies
- remove references to e2e in sample workspace as there are no e2e tests
- replace deprecated `async()` with `waitForAsync()` in tests
- add tsconfig.server.json to list of files for linting
- fix tests prompting to enable Angular CLI analytics
Copy link
Member

@jamesdaniels jamesdaniels left a comment

LGTM, thanks! Good catch on the remaining provider.

@jamesdaniels jamesdaniels merged commit ebf537e into angular:master Sep 25, 2020
3 checks passed
@Splaktar Splaktar deleted the angular-v10-migrations branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants