Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Account for incorrect impl Foo<const N: ty> {} syntax
#85346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
|
Error message looks good to me! @bors r+ |
|
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 17, 2021
Account for incorrect `impl Foo<const N: ty> {}` syntax
Fix rust-lang#84946
This comment has been hidden.
This comment has been hidden.
|
|
|
|
|
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
|
cc @estebank: this is waiting on a rebase. |
|
@bors r=varkor |
|
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 20, 2021
Account for incorrect `impl Foo<const N: ty> {}` syntax
Fix rust-lang#84946
|
Added the requested tests, and fixed the necessary rebase moving some code to the more appropriate @bors r=nagisa,varkor |
|
|
This comment has been hidden.
This comment has been hidden.
|
Forgot to @bors r=nagisa,varkor |
|
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Nov 25, 2021
Account for incorrect `impl Foo<const N: ty> {}` syntax
Fix rust-lang#84946
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
|
|
@bors retry |
|
|
|
Finished benchmarking commit (c6eda7d): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
terrarier2111
added a commit
to terrarier2111/rust
that referenced
this issue
Nov 27, 2021
Use the available Generics span field to avoid issues with `T: Fn()` bounds. This is necessary to land rust-lang#85346.
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this issue
Dec 3, 2021
Use the available Generics span field to avoid issues with `T: Fn()` bounds. This is necessary to land rust-lang#85346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix #84946
The text was updated successfully, but these errors were encountered: