MAINT add manifest check in circle ci config #18128
Conversation
Since our circleci instances are limited. Can we move this check to azure pipelines or github actions and have it run nightly on master? |
Hi @nixphix are you still interested in working on this? If so, aside from @thomasjpfan's comment, it's currently failing due to:
I think these should be added to the whitelist in setup.py. |
@lucyleeow will update the PR with GH action |
@thomasjpfan this is the suggestion from check-manifest now, should I build sklearn to generate these files? or add it to the exclude list? Here you can find the build log missing from VCS:
sklearn/linear_model/_sag_fast.pyx
sklearn/utils/_seq_dataset.pxd
sklearn/utils/_seq_dataset.pyx |
They should be excluded from the maniftest. |
I have added the files to ignore list now the check is passing |
33ae62d
to
625b47f
Minor comment, otherwise LGTM |
3c62364
into
scikit-learn:master
Reference Issues/PRs
Fixes #13916
What does this implement/fix? Explain your changes.
Adds manifest check in circle ci set up to check if MANIFEST.in is missing any file.
Any other comments?
Should we run this check as cron job or only on master branch?
Shall I update the
MANIFEST.in
with the suggestion from the check-manifest package?