The Wayback Machine - https://web.archive.org/web/20210724220605/https://github.com/home-assistant/core/pull/36933
Skip to content

/ core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlight Dockerfile.dev as Dockerfile in github ui #36933

Merged
merged 1 commit into from Jun 22, 2020
Merged

highlight Dockerfile.dev as Dockerfile in github ui #36933

merged 1 commit into from Jun 22, 2020

Conversation

@adaamz
Copy link
Contributor

@adaamz adaamz commented Jun 19, 2020 •
edited

Proposed change

Use Dockerfile syntax highlighter for Dockerfile.dev file.

Type of change

  • Code quality improvements to existing code or addition of tests

More info at
https://github.com/github/linguist#overrides

I have merged this PR into my fork's dev branch, check it here https://github.com/adaamz/core/blob/dev/Dockerfile.dev
@adaamz
highlight Dockerfile.dev as Dockerfile in github ui
0c3b577
@homeassistant
Copy link
Contributor

@homeassistant homeassistant commented Jun 19, 2020

Hi @adaamz,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!
@project-bot project-bot bot added this to Needs review in Dev Jun 19, 2020
@frenck
frenck approved these changes Jun 22, 2020
View changes
Copy link
Member

@frenck frenck left a comment

Thanks, @adaamz 👍
Dev automation moved this from Needs review to Reviewer approved Jun 22, 2020
@frenck frenck merged commit 0054904 into home-assistant:dev Jun 22, 2020
13 checks passed
13 checks passed
@azure-pipelines
CI Build #20200619.18 succeeded
Details
@azure-pipelines
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
@azure-pipelines
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
@azure-pipelines
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
@azure-pipelines
CI (Overview Docker) Overview Docker succeeded
Details
@azure-pipelines
CI (Overview Lint) Overview Lint succeeded
Details
@azure-pipelines
CI (Overview Validate) Overview Validate succeeded
Details
@azure-pipelines
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
@azure-pipelines
CI (Tests PyTest Python38) Tests PyTest Python38 succeeded
Details
@homeassistant
cla-bot All contributors have signed the CLA
@codecov
codecov/patch Coverage not affected when comparing 2126603...0c3b577
Details
@codecov
codecov/project 95.52% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jun 22, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck

Assignees
No one assigned
Labels
cla-signed code-quality small-pr
Projects
Dev
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@adaamz @homeassistant @frenck