The Wayback Machine - https://web.archive.org/web/20210724220902/https://github.com/home-assistant/core/pull/39501
Skip to content

/ core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Automate Pulse Hub v2 support #39501

Merged
merged 42 commits into from Jul 22, 2021
Merged

Add Automate Pulse Hub v2 support #39501

merged 42 commits into from Jul 22, 2021

Conversation

@sillyfrog
Copy link
Contributor

@sillyfrog sillyfrog commented Aug 31, 2020 •
edited

Proposed change

Support for the Automate Pulse Hub v2. This is the next generation of hub from Rollease Acmeda. It uses the "Automate" branding, and a completely different network protocol.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

  • I have reviewed two other open pull requests in this repository.
    Started a code review, and putting together a number of examples and updating documentation. :)
sillyfrog added 3 commits Aug 31, 2020
@sillyfrog
Initial scaffold
68596ee
@sillyfrog
Add Automate Pulse Hub v2 support
f80b366
@sillyfrog
Minor improvements
420e197
This was referenced Aug 31, 2020
Merged
Merged
@sillyfrog
Fix pylint errors
99812df
@frenck frenck added this to Incoming in New Integrations via automation Aug 31, 2020
@sillyfrog
Exclude integration requiring external devices
9835088
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Sep 1, 2020
sillyfrog added 2 commits Sep 3, 2020
@sillyfrog
Move default data setup to correct location
abe0801
@sillyfrog
Remove usage of const.UNIT_PERCENTAGE
a4a8ed3
@frenck
frenck requested changes Nov 21, 2020
View changes
Copy link
Member

@frenck frenck left a comment

Thanks for the PR! I've added some initial comments to get this started 👍
.coveragerc Outdated Show resolved Hide resolved
homeassistant/components/automate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/automate/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/automate/strings.json Outdated Show resolved Hide resolved
homeassistant/components/automate/translations/en.json Show resolved Hide resolved
homeassistant/components/automate/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/automate/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/automate/cover.py Show resolved Hide resolved
homeassistant/components/automate/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/automate/__init__.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 21, 2020
New Integrations automation moved this from Incoming to Awaiting Requested Changes Nov 21, 2020
sillyfrog added 7 commits Nov 22, 2020
@sillyfrog
Updates for code review
12771bc
@sillyfrog
Merge branch 'dev' into automate-covers
f3b35e0
@sillyfrog
Update requirements*.txt
ca1e02e
@sillyfrog
Merge branch 'automate-covers' of github.com:sillyfrog/core into auto…
517bf45 
…mate-covers
@sillyfrog
Remove unused import
bb8d2e8
@sillyfrog
Run script.hassfest
3b296a9
@sillyfrog
Update to allow testing
543749e
@sillyfrog sillyfrog requested a review from frenck Nov 22, 2020
@sillyfrog
Copy link
Contributor Author

@sillyfrog sillyfrog commented Nov 22, 2020 •
edited

@frenck Thanks for starting this. I have requested a re-review of my changes so far. I have tried to resolve the ones that were easily fixed, and leave the others open. Sorry for the false starts. It's been a while and VScode rebuilt my container - and I forgot to manually install all of the required test packages (so I didn't commit failures).
sillyfrog added 3 commits Nov 22, 2020
@sillyfrog
Modify tests to increase coverage
32d15dd
@sillyfrog
isort imports in tests
5664b04
@sillyfrog
Doc string
0c17c55
@github-actions github-actions bot removed the stale label Jun 12, 2021
@frenck
frenck reviewed Jun 15, 2021
View changes
homeassistant/components/automate/__init__.py Show resolved Hide resolved
homeassistant/components/automate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/automate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/automate/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/automate/base.py Outdated Show resolved Hide resolved
tests/components/automate/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/automate/test_config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/automate/base.py Outdated Show resolved Hide resolved
homeassistant/components/automate/helpers.py Outdated Show resolved Hide resolved
homeassistant/components/automate/hub.py Outdated Show resolved Hide resolved
sillyfrog and others added 11 commits Jun 15, 2021
@sillyfrog @frenck
Update homeassistant/components/automate/__init__.py
db609d2 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog @frenck
Update homeassistant/components/automate/__init__.py
196526b 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog @frenck
Update homeassistant/components/automate/__init__.py
60e916f 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog @frenck
Update homeassistant/components/automate/__init__.py
9681f49 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog
Merge branch 'home-assistant:dev' into automate-covers
1b1ffb0
@sillyfrog @frenck
Update homeassistant/components/automate/config_flow.py
f4ee89c 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog @frenck
Update homeassistant/components/automate/helpers.py
5aef586 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog @frenck
Update homeassistant/components/automate/config_flow.py
8b8567d 
Co-authored-by: Franck Nijhof <[email protected]>
@sillyfrog
Updates as per code review
b445032
@sillyfrog
Test updates as per code review
1e7c628
@sillyfrog
Merge branch 'automate-covers' of github.com:sillyfrog/core into auto…
bb45ba9 
…mate-covers
@sillyfrog
Copy link
Contributor Author

@sillyfrog sillyfrog commented Jun 15, 2021

Thanks @frenck. I have just pushed all of those changes now and update as suggested. Cheers.
@thecode thecode mentioned this pull request Jun 27, 2021
Closed
sillyfrog added 2 commits Jun 28, 2021
@sillyfrog
Merge remote-tracking branch 'upstream/dev' into automate-covers
4c2bdcd
@sillyfrog
Updates for latest HA checks
ef48a4a
@frenck frenck added the smash label Jul 21, 2021
@frenck frenck self-requested a review Jul 21, 2021
sillyfrog added 3 commits Jul 22, 2021
@sillyfrog
Merge branch 'home-assistant:dev' into automate-covers
5355224
@sillyfrog
Update for latest isort changes
d742a2b
@sillyfrog
Merge branch 'automate-covers' of github.com:sillyfrog/core into auto…
4a16282 
…mate-covers
Dev automation moved this from Review in progress to Reviewer approved Jul 22, 2021
@frenck
frenck approved these changes Jul 22, 2021
View changes
Copy link
Member

@frenck frenck left a comment

This PR looks good to me, thanks @sillyfrog 👍

For a follow-up PR, you could look into things like typing, and the use of entity class and instance attributes (https://developers.home-assistant.io/docs/core/entity#entity-class-or-instance-attributes). Those are some nice improvements (but not requirements at this point).

Thanks again! 👍
New Integrations automation moved this from Needs followup review to Reviewer approved Jul 22, 2021
@frenck frenck merged commit d3e77e0 into home-assistant:dev Jul 22, 2021
30 checks passed
30 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2) Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2) Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch 100.00% of diff hit (target 96.48%)
Details
@codecov
codecov/project 96.49% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jul 22, 2021
New Integrations automation moved this from Reviewer approved to Done Jul 22, 2021
raman325 added a commit to raman325/home-assistant that referenced this pull request Jul 22, 2021
@raman325
Merge remote-tracking branch 'upstream/dev' into device_trigger
7e451db 
* upstream/dev: (229 commits)
  Use entity class attributes for canary (home-assistant#53333)
  Update to PyVicare 1.0 (home-assistant#53281)
  Do not automatically add title to strings.json (home-assistant#53350)
  Replace util.get_local_ip in favor of components.network.async_get_source_ip() - part 1 (home-assistant#52980)
  Create APIs for Insteon panel (home-assistant#49785)
  Bump aionotion to 3.0.2 (home-assistant#53354)
  Handle more Sonos snapshot restore scenarios (home-assistant#53277)
  Making Pytest default for VS code (home-assistant#53203)
  Fix for issue home-assistant#53031 (home-assistant#53343)
  Add state class and last reset to consumption sensor in devolo Home Control (home-assistant#53337)
  Fritzbox enable temp sensor (home-assistant#52558)
  Upgrade wled to 0.7.3 (home-assistant#53340)
  Use NamedTuple - rainbird (home-assistant#53329)
  Use entity class attributes for caldav (home-assistant#53332)
  Add Automate Pulse Hub v2 support (home-assistant#39501)
  Switch wirelesstag to use cloud push (home-assistant#50984)
  Remove energy attributes from switch platform in devolo Home Control (home-assistant#53335)
  Add a homekit.unpair service to forcefully remove pairings (home-assistant#53303)
  Use NamedTuple - rova (home-assistant#53292)
  Speedtestdotnet code cleanup and type hints (home-assistant#52533)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck

Assignees
No one assigned
Labels
cla-signed has-tests integration: automate new-integration smash
Projects
Dev
  
Done
New Integrations
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sillyfrog @frenck @homeassistant