The Wayback Machine - https://web.archive.org/web/20210724220531/https://github.com/home-assistant/core/pull/50850
Skip to content

/ core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yale_smart_alarm config flow and coordinator #50850

Merged
merged 39 commits into from Jul 24, 2021
Merged

Add yale_smart_alarm config flow and coordinator #50850

merged 39 commits into from Jul 24, 2021
+725 −60

Conversation

@gjohansson-ST
Copy link
Contributor

@gjohansson-ST gjohansson-ST commented May 19, 2021 •
edited by raman325

Breaking change

Config flow support has been added to yale_smart_alarm. Existing YAML configuration entries will be imported automatically but should be removed from YAML configuration after import. Import support will be removed in a future release.

Proposed change

  • Add config flow to enable setup from UI (migrates from yaml)
  • Add coordinator to accommodate updates and enable future platforms to be added easily

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:
@project-bot project-bot bot added this to Needs review in Dev May 19, 2021
@MartinHjelmare MartinHjelmare changed the title config flow and coordinator Add yale_smart_alarm config flow and coordinator May 19, 2021
@gjohansson-ST gjohansson-ST mentioned this pull request May 19, 2021
Closed
3 of 8 tasks
@gjohansson-ST gjohansson-ST marked this pull request as ready for review May 19, 2021
@gjohansson-ST gjohansson-ST marked this pull request as draft May 19, 2021
@gjohansson-ST gjohansson-ST marked this pull request as ready for review May 20, 2021
@gjohansson-ST gjohansson-ST mentioned this pull request May 20, 2021
Merged
3 of 8 tasks
@oyvindwe
oyvindwe suggested changes May 20, 2021
View changes
homeassistant/components/yale_smart_alarm/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/strings.json Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress May 20, 2021
@oyvindwe
oyvindwe suggested changes May 21, 2021
View changes
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
@oyvindwe
oyvindwe suggested changes May 21, 2021
View changes
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
@oyvindwe
oyvindwe suggested changes May 21, 2021
View changes
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
@oyvindwe
oyvindwe approved these changes May 22, 2021
View changes
homeassistant/components/yale_smart_alarm/config_flow.py Outdated Show resolved Hide resolved
@gjohansson-ST gjohansson-ST force-pushed the gjohansson-ST:yale-2 branch from a6b2f8e to 0253a65 May 22, 2021
@oyvindwe
oyvindwe approved these changes May 22, 2021
View changes
@gjohansson-ST gjohansson-ST mentioned this pull request May 24, 2021
Closed
@oyvindwe
oyvindwe approved these changes May 24, 2021
View changes
@oyvindwe
oyvindwe approved these changes May 24, 2021
View changes
@gjohansson-ST
Copy link
Contributor Author

@gjohansson-ST gjohansson-ST commented May 28, 2021

@MartinHjelmare is it possible you can move me back to the "by code owner" bucket as I have a hunch I'm not getting a core developer to look at this sitting in the "review in progress" as no such is taking place. Thanks
@MartinHjelmare MartinHjelmare moved this from Review in progress to By Code Owner in Dev May 28, 2021
@gjohansson-ST
config flow and coordinator
93c625b
@gjohansson-ST
comply with pylint
1c9dd63
@gjohansson-ST
Remove pylint errors
cd18b6e
@gjohansson-ST
Update test coverage yale smart alarm
7f080a6
@gjohansson-ST
Update test config_flow
608f173
@gjohansson-ST
Fix test already configured
4498e22
@MartinHjelmare
MartinHjelmare reviewed Jul 20, 2021
View changes
homeassistant/components/yale_smart_alarm/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
@gjohansson-ST
Corrections from PR review no 5
8dd29f8
@gjohansson-ST gjohansson-ST requested a review from MartinHjelmare Jul 20, 2021
@MartinHjelmare
MartinHjelmare reviewed Jul 23, 2021
View changes
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
@gjohansson-ST
Corrections from PR review no 6
aca0149
@gjohansson-ST gjohansson-ST requested a review from MartinHjelmare Jul 23, 2021
@gjohansson-ST
Corrections from PR review no 6_2
1b7bd20
@MartinHjelmare
MartinHjelmare reviewed Jul 23, 2021
View changes
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
@gjohansson-ST
Corrections from PR review no 7
fd86e38
@gjohansson-ST gjohansson-ST requested a review from MartinHjelmare Jul 23, 2021
@MartinHjelmare
MartinHjelmare approved these changes Jul 23, 2021
View changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Looks good!
@MartinHjelmare
MartinHjelmare requested changes Jul 23, 2021
View changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Sorry. I found some more things.
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
@MartinHjelmare
MartinHjelmare reviewed Jul 23, 2021
View changes
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
@gjohansson-ST
Copy link
Contributor Author

@gjohansson-ST gjohansson-ST commented Jul 23, 2021

Sorry. I found some more things.

LOL. I surely hope it's the last things you find 😄
Hope it can be merged in now so I can start with next PR 👍
@gjohansson-ST
Corrections from PR review no 8
38d8137
@gjohansson-ST gjohansson-ST requested a review from MartinHjelmare Jul 23, 2021
@MartinHjelmare
MartinHjelmare approved these changes Jul 23, 2021
View changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Thanks!
Dev automation moved this from Review in progress to Reviewer approved Jul 24, 2021
@raman325
raman325 approved these changes Jul 24, 2021
View changes
Copy link
Contributor

@raman325 raman325 left a comment

nice work on this, just a few ideas to reduce headaches later
homeassistant/components/yale_smart_alarm/coordinator.py Show resolved Hide resolved
homeassistant/components/yale_smart_alarm/alarm_control_panel.py Outdated Show resolved Hide resolved
@gjohansson-ST
Minor last changes for PR
202d15a
@gjohansson-ST
Copy link
Contributor Author

@gjohansson-ST gjohansson-ST commented Jul 24, 2021

I did now implement for the last comments.
What's the process now to get this PR merged?
@raman325
Copy link
Contributor

@raman325 raman325 commented Jul 24, 2021 •
edited

I did now implement for the last comments.
What's the process now to get this PR merged?

We can merge as soon as tests pass! Looks like there's a pylint failure that needs to be addressed. Went ahead and committed a fix for it
@raman325
raman325 reviewed Jul 24, 2021
View changes
homeassistant/components/yale_smart_alarm/coordinator.py Outdated Show resolved Hide resolved
@raman325
Update homeassistant/components/yale_smart_alarm/coordinator.py
40e7487
@raman325
Copy link
Contributor

@raman325 raman325 commented Jul 24, 2021 •
edited

last thing I did btw was mark this as a breaking change so that it's highlighted in the release docs that configuration.yaml configuration is deprecated
@raman325 raman325 merged commit f0d5ae2 into home-assistant:dev Jul 24, 2021
30 checks passed
30 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch 100.00% of diff hit (target 96.45%)
Details
@codecov
codecov/project 96.50% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare

@raman325 raman325

@oyvindwe oyvindwe

@Mr-Grover Mr-Grover

Assignees
No one assigned
Labels
almost-done breaking-change by-code-owner cla-signed has-tests integration: yale_smart_alarm
Projects
Dev
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@gjohansson-ST @diazwatson @Mr-Grover @MartinHjelmare @raman325 @oyvindwe @frenck @homeassistant