The Wayback Machine - https://web.archive.org/web/20210724221242/https://github.com/home-assistant/core/pull/52972
Skip to content

/ core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint 2.9.3 #52972

Merged
merged 13 commits into from Jul 15, 2021
Merged

Pylint 2.9.3 #52972

merged 13 commits into from Jul 15, 2021
+182 −213

Conversation

@Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Jul 13, 2021 •
edited

Breaking change

Proposed change

Upgrade pylint to 2.9.3
http://pylint.pycqa.org/en/latest/whatsnew/2.9.html

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:
@Danielhiversen
upgrade pylint, wip
5f9027b 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@Danielhiversen
upgrade pylint
f11ef72 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@project-bot project-bot bot added this to Needs review in Dev Jul 13, 2021
@Danielhiversen
Danielhiversen reviewed Jul 13, 2021
View changes
homeassistant/components/snmp/switch.py Outdated Show resolved Hide resolved
@Danielhiversen
upgrade pylint
22cfd59 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@Danielhiversen
upgrade pylint
3cc83f9 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@Danielhiversen
upgrade pylint
71a82fa 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@Danielhiversen
upgrade pylint
a3e75cd 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@frenck frenck changed the title Pylint Pylint 2.9.3 Jul 13, 2021
@cdce8p
Remove useless suppressions
5dbf674
@cdce8p
cdce8p reviewed Jul 14, 2021
View changes
Copy link
Member

@cdce8p cdce8p left a comment

Thank you @Danielhiversen for doing the work and updating the code 🚀
I just pushed a commit to remove some pylint: disable comments that have become useless with the new version.

The changes itself look good, just a few comments.

--
Pylint 2.9 also adds the Code Style extension: pylint.extensions.code_style which could be quite useful for us. Although it might make sense to add it in a separate PR as it will also require some changes.
http://pylint.pycqa.org/en/latest/technical_reference/extensions.html#code-style-checker
homeassistant/components/google/__init__.py Show resolved Hide resolved
homeassistant/components/mysensors/light.py Outdated Show resolved Hide resolved
homeassistant/components/rpi_camera/camera.py Outdated Show resolved Hide resolved
homeassistant/components/rpi_camera/camera.py Outdated Show resolved Hide resolved
homeassistant/components/snmp/switch.py Outdated Show resolved Hide resolved
cdce8p and others added 4 commits Jul 14, 2021
@cdce8p
Re-add disable for import-error
268a755
@Danielhiversen @cdce8p
Update homeassistant/components/rpi_camera/camera.py
7aa0af4 
Co-authored-by: Marc Mueller <[email protected]>
@Danielhiversen @cdce8p
Update homeassistant/components/rpi_camera/camera.py
5a7ed0d 
Co-authored-by: Marc Mueller <[email protected]>
@Danielhiversen
pylint
9210fce 
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@Danielhiversen
Danielhiversen reviewed Jul 14, 2021
View changes
homeassistant/components/esphome/binary_sensor.py Show resolved Hide resolved
@Danielhiversen
Update homeassistant/components/snmp/switch.py
c7f304e
@cdce8p
cdce8p approved these changes Jul 14, 2021
View changes
Copy link
Member

@cdce8p cdce8p left a comment

LGTM
Dev automation moved this from Needs review to Reviewer approved Jul 14, 2021
@cdce8p
Copy link
Member

@cdce8p cdce8p commented Jul 14, 2021

@frenck Can this PR be merged once all the tests pass or would you like to wait to make patch release a bit easier? Not sure if this one would have an impact at all.
@cdce8p
Merge remote-tracking branch 'upstream/dev' into pylint
69f9986
@balloob balloob merged commit fbad453 into dev Jul 15, 2021
33 checks passed
33 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2) Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2) Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@azure-pipelines
Core This check was skipped
Details
@azure-pipelines
Release This check was skipped
Details
@azure-pipelines
Translation - Backend This check was skipped
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch 100.00% of diff hit (target 96.44%)
Details
@codecov
codecov/project 96.44% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
@balloob balloob deleted the pylint branch Jul 15, 2021
Dev automation moved this from Reviewer approved to Done Jul 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mich-b Mich-b

@cdce8p cdce8p

Assignees
No one assigned
Labels
cla-signed code-quality core dependency
Projects
Dev
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Danielhiversen @cdce8p @Mich-b @balloob @homeassistant