The Wayback Machine - https://web.archive.org/web/20210724220516/https://github.com/home-assistant/core/pull/53355
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce strict typing for Notion #53355

Merged
merged 2 commits into from Jul 23, 2021
Merged

Conversation

@bachya
Copy link
Contributor

@bachya bachya commented Jul 22, 2021

Proposed change

This PR enforces strict mypy typing for Notion.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Jul 22, 2021
@project-bot project-bot bot added this to Needs review in Dev Jul 22, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 22, 2021
@bachya bachya force-pushed the bachya:notion-strict-typing branch from e080241 to 8586941 Jul 22, 2021
@bachya bachya marked this pull request as ready for review Jul 22, 2021
@bachya bachya changed the title Notion strict typing Enforce strict typing with Notion Jul 22, 2021
@bachya bachya changed the title Enforce strict typing with Notion Enforce strict typing for Notion Jul 22, 2021
@frenck frenck added the smash label Jul 22, 2021
@cgtobi
cgtobi approved these changes Jul 23, 2021
Copy link
Contributor

@cgtobi cgtobi left a comment

LGTM

Dev automation moved this from By Code Owner to Reviewer approved Jul 23, 2021
@bachya bachya merged commit 4b35391 into home-assistant:dev Jul 23, 2021
30 checks passed
30 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch Coverage not affected when comparing b2528e9...e95a6fc
Details
@codecov
codecov/project 96.50% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jul 23, 2021
@bachya bachya deleted the bachya:notion-strict-typing branch Jul 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants