The Wayback Machine - https://web.archive.org/web/20210719173738/https://github.com/laravel/laravel/pull/5574
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Rename test methods #5574

Merged
merged 1 commit into from Mar 26, 2021
Merged

[8.x] Rename test methods #5574

merged 1 commit into from Mar 26, 2021

Conversation

@driesvints
Copy link
Member

@driesvints driesvints commented Mar 26, 2021

We decided a while back to go for snake case as our convention for methods names in tests. All of our other first party libraries except for the framework are already on this convention. This PR moves the skeleton to the same convention. We'll convert the framework as well at some point.

Note that these new method names reflect the ones from the stub files in the framework when scaffolding a test using make:test. This also removes the duplicate "test" word.

@taylorotwell taylorotwell merged commit 5808129 into 8.x Mar 26, 2021
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@taylorotwell taylorotwell deleted the test-names branch Mar 26, 2021
imabug added a commit to imabug/raddb that referenced this pull request Mar 27, 2021
keljtanoski added a commit to keljtanoski/laravel that referenced this pull request Mar 31, 2021
imabug added a commit to imabug/raddb2 that referenced this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants