The Wayback Machine - https://web.archive.org/web/20210725230326/https://github.com/home-assistant/core/pull/44743
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop remaining Python < 3.8 support #44743

Merged
merged 11 commits into from Jan 4, 2021
Merged

Drop remaining Python < 3.8 support #44743

merged 11 commits into from Jan 4, 2021

Conversation

@scop
Copy link
Member

@scop scop commented Jan 1, 2021

Proposed change

Some leftovers on top of #43805

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: #43805
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

tox.ini Outdated Show resolved Hide resolved
azure-pipelines-release.yml Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Jan 1, 2021
tests/async_mock.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@frenck
frenck approved these changes Jan 4, 2021
Copy link
Member

@frenck frenck left a comment

Fixed the last isort issue, LGTM 👍

Thanks, @scop and Happy New Year 🥂

Dev automation moved this from Review in progress to Reviewer approved Jan 4, 2021
@frenck frenck merged commit 4347476 into home-assistant:dev Jan 4, 2021
30 checks passed
30 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch 100.00% of diff hit (target 96.27%)
Details
@codecov
codecov/project 96.28% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jan 4, 2021
@scop scop deleted the scop:drop-remaining-py38 branch Jan 4, 2021
KJonline pushed a commit to Pyhass/core that referenced this pull request Jan 4, 2021
* 'dev' of https://github.com/home-assistant/core: (207 commits)
  Fix zeroconf outgoing dns compression corruption for large packets (home-assistant#44828)
  Move RainMachine services to entity services (home-assistant#44139)
  Updated Ondilo translation files to remove title (home-assistant#44824)
  Adjust system info for lovelace with multiple dashboards (home-assistant#44796)
  Add Ondilo ico integration (home-assistant#44728)
  Fix Fan support in nest climate by adding HVAC_MODE_FAN_ONLY support (home-assistant#44203)
  Add device entry id to events (home-assistant#44407)
  Try to fix flaky Risco test (home-assistant#44788)
  Add myself to codeowners for Shelly (home-assistant#44814)
  Cleanup timeouts values for Shelly (home-assistant#44790)
  Change rest sensors update interval for Shelly Motion (home-assistant#44692)
  Add more debug details to running timeouts (home-assistant#43644)
  Change WHITELIST to ALLOWLIST for websockets (home-assistant#44766)
  Fix bug with blink auth flow (home-assistant#44769)
  Fix race when handling MQTT discovery messages (home-assistant#44730)
  Drop remaining Python < 3.8 support (home-assistant#44743)
  Bump pyobihai (home-assistant#44768)
  Add index to old_state_id column for postgres and older databases (home-assistant#44757)
  Bumo pyroon version to 0.0.30 (home-assistant#44800)
  Update to denonavr version 0.9.10 (home-assistant#44791)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants