The Wayback Machine - https://web.archive.org/web/20220325141111/https://github.com/HeroTransitions/Hero/issues/171
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash during transition #171

Open
hmvr414 opened this issue Apr 3, 2017 · 14 comments
Open

Crash during transition #171

hmvr414 opened this issue Apr 3, 2017 · 14 comments
Labels
confirmed bug good first issue
Milestone
1.7.0

Comments

@hmvr414
Copy link

@hmvr414 hmvr414 commented Apr 3, 2017

Hi,

I'm having the following crash, sometimes in a transition:

Crashed: com.apple.main-thread
0 Hero 0x102bc6940 HeroContext.snapshotView(for : UIView) -> UIView (HeroContext.swift:182)
1 Hero 0x102bfdbbc HeroDefaultAnimator.animate(view : UIView, appearing : Bool) -> () (HeroDefaultAnimator.swift:107)
2 Hero 0x102bfcea0 HeroDefaultAnimator.animate(fromViews : [UIView], toViews : [UIView]) -> Double (HeroDefaultAnimator.swift)
3 Hero 0x102bfe670 protocol witness for HeroAnimator.animate(fromViews : [UIView], toViews : [UIView]) -> Double in conformance <A where ...> HeroDefaultAnimator (HeroDefaultAnimator.swift)
4 Hero 0x102bbedc0 HeroBaseController.animate() -> () (HeroBaseController.swift:307)
5 Hero 0x102bbef80 @objc HeroBaseController.animate() -> () (HeroBaseController.swift)
6 Hero 0x102bb30fc Hero.animate() -> () (Hero.swift:202)
7 Hero 0x102bb34cc @objc Hero.animate() -> () (Hero.swift)
8 Hero 0x102bb2b54 Hero.start() -> () (Hero.swift:189)
9 Hero 0x102bb2cfc @objc Hero.start() -> () (Hero.swift)
10 Hero 0x102bb6078 @objc Hero.animateTransition(using : UIViewControllerContextTransitioning) -> () (Hero.swift)
11 UIKit 0x18d10d30c __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 2128
12 UIKit 0x18d04ffdc _runAfterCACommitDeferredBlocks + 292
13 UIKit 0x18d041d50 _cleanUpAfterCAFlushAndRunDeferredBlocks + 560
14 UIKit 0x18cdb10b4 _afterCACommitHandler + 168
15 CoreFoundation 0x186eb60c0 CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION + 32
16 CoreFoundation 0x186eb3cf0 __CFRunLoopDoObservers + 372
17 CoreFoundation 0x186eb4180 __CFRunLoopRun + 1024
18 CoreFoundation 0x186de22b8 CFRunLoopRunSpecific + 444
19 GraphicsServices 0x188896198 GSEventRunModal + 180
20 UIKit 0x18ce297fc -[UIApplication _run] + 684
21 UIKit 0x18ce24534 UIApplicationMain + 208
22 Grability 0x1003edb24 main (main.m:17)
23 libdispatch.dylib 0x185dc55b8 (Missing)
@martnst
Copy link

@martnst martnst commented Apr 10, 2017

I have the same issue: it crashes here: https://github.com/lkzhao/Hero/blob/master/Sources/Extensions/UIView%2BHero.swift#L74

@posix88
Copy link

@posix88 posix88 commented Jun 13, 2017

I have the same issue and also a strange Crash on

https://github.com/lkzhao/Hero/blob/master/Sources/Hero.swift#L141

@danywarner
Copy link

@danywarner danywarner commented Jul 5, 2017 •
edited

I'm using Crashlytics and I got a popular crash on UIView+Hero.swift
specifically because of this force unwrap:
var snapshot = snapshotView(afterScreenUpdates: true)!
That is the same crash @hmvr414 talks about

@AkitakiLab
Copy link

@AkitakiLab AkitakiLab commented Jul 22, 2017

I've got a similar crash using Hero 0.3.6:

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   Hero                          	0x005b6f3c Hero.start() -> () (Hero.swift:140)
1   Hero                          	0x005b6498 Hero.start() -> () (Hero.swift:140)
2   Hero                          	0x005b6f68 @objc Hero.start() -> () (Hero.swift:0)
3   Hero                          	0x005b97e8 @objc Hero.animateTransition(using : UIViewControllerContextTransitioning) -> () (Hero.swift:0)
4   UIKit                         	0x223dedd0 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 2864
5   UIKit                         	0x22324dc2 _runAfterCACommitDeferredBlocks + 276
6   UIKit                         	0x223180d2 _cleanUpAfterCAFlushAndRunDeferredBlocks + 524
7   UIKit                         	0x22099cfc _afterCACommitHandler + 112
8   CoreFoundation                	0x1ce33802 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 20
9   CoreFoundation                	0x1ce31a54 __CFRunLoopDoObservers + 282
10  CoreFoundation                	0x1ce32016 __CFRunLoopRun + 1358
11  CoreFoundation                	0x1cd850ee CFRunLoopRunSpecific + 470
12  CoreFoundation                	0x1cd84f10 CFRunLoopRunInMode + 104
13  GraphicsServices              	0x1e52fb40 GSEventRunModal + 80
14  UIKit                         	0x22109e82 UIApplicationMain + 150

@AkitakiLab
Copy link

@AkitakiLab AkitakiLab commented Jul 26, 2017

Here's another report of (probably) the same bug.
Due to unknown problem, I couldn't fully symbolicate it, though.

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   Hero                          	0x00757e8c 0x727000 + 200332
1   Hero                          	0x00757494 0x727000 + 197780
2   Hero                          	0x0075a840 0x727000 + 211008
3   UIKit                         	0x223dedd0 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 2864
4   UIKit                         	0x22324dc2 _runAfterCACommitDeferredBlocks + 276
5   UIKit                         	0x223180d2 _cleanUpAfterCAFlushAndRunDeferredBlocks + 524
6   UIKit                         	0x22099cfc _afterCACommitHandler + 112
7   CoreFoundation                	0x1ce33802 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 20
8   CoreFoundation                	0x1ce31a54 __CFRunLoopDoObservers + 282
9   CoreFoundation                	0x1ce32016 __CFRunLoopRun + 1358
10  CoreFoundation                	0x1cd850ee CFRunLoopRunSpecific + 470
11  CoreFoundation                	0x1cd84f10 CFRunLoopRunInMode + 104
12  GraphicsServices              	0x1e52fb40 GSEventRunModal + 80
13  UIKit                         	0x22109e82 UIApplicationMain + 150
14  MineRimoto                    	0x000e2b50 0xdd000 + 23376
15  libdyld.dylib                 	0x1c5724ea start + 2

@karlisl
Copy link

@karlisl karlisl commented Aug 11, 2017

Same crash happening here:

Thread 0 name: 
Thread 0 Crashed:
0   Hero                            0x1009f61d4         Hero.start() -> () (Hero.swift:140)
1   Hero                            0x1009f6204         @objc Hero.start() -> ()
2   Hero                            0x1009f8390         [inlined] Hero.animateTransition(using : UIViewControllerContextTransitioning) -> ()
3   Hero                            0x1009f8390         @objc Hero.animateTransition(using : UIViewControllerContextTransitioning) -> ()
4   UIKit                           0x319abc30c         __56-[UIPresentationController runTransitionForCurrentState]_block_invoke
5   UIKit                           0x3199fefdc         _runAfterCACommitDeferredBlocks
6   UIKit                           0x3199f0d50         _cleanUpAfterCAFlushAndRunDeferredBlocks
7   UIKit                           0x3197600b4         _afterCACommitHandler
8   CoreFoundation                  0x30d88f0c0         __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
9   CoreFoundation                  0x30d88ccf0         __CFRunLoopDoObservers
10  CoreFoundation                  0x30d88d180         __CFRunLoopRun
11  CoreFoundation                  0x30d7bb2b8         CFRunLoopRunSpecific
12  GraphicsServices                0x310d20198         GSEventRunModal
13  UIKit                           0x3197d87fc         -[UIApplication _run]
14  UIKit                           0x3197d3534         UIApplicationMain

@Athosone
Copy link

@Athosone Athosone commented Oct 2, 2017

Any news about it ?

@aliabduljabbar
Copy link

@aliabduljabbar aliabduljabbar commented Nov 20, 2017

anything that solved this crash ?

@lkzhao lkzhao closed this Nov 22, 2017
@kylebrowning
Copy link

@kylebrowning kylebrowning commented Feb 7, 2018

@lkzhao Why is this closed? It needs to be re-opened.

0  Hero                           0x1011d74d8 specialized HeroContext.snapshotView(for:) (HeroContext.swift:212)
1  Hero                           0x10122a994 HeroTransition.animate() (HeroTransition+Animate.swift:50)
2  Hero                           0x101225790 partial apply for closure #6 in HeroTransition.start() (HeroTransition+Start.swift:157)
3  Hero                           0x101224cc4 thunk for @callee_owned () -> () (HeroTransition+Start.swift)
4  libdispatch.dylib              0x182356a54 _dispatch_call_block_and_release + 24
5  libdispatch.dylib              0x182356a14 _dispatch_client_callout + 16
6  libdispatch.dylib              0x182363698 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1016
7  CoreFoundation                 0x18297f344 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
8  CoreFoundation                 0x18297cf20 __CFRunLoopRun + 2012
9  CoreFoundation                 0x18289cc58 CFRunLoopRunSpecific + 436
10 GraphicsServices               0x184748f84 GSEventRunModal + 100```

@lkzhao
Copy link
Collaborator

@lkzhao lkzhao commented Feb 7, 2018 •
edited

@kylebrowning Can you checkout the master version and see if it is still crashing for you. We dont use force unwrap when calling snapshotView(for:) anymore and it shouldn't crash.

@kylebrowning
Copy link

@kylebrowning kylebrowning commented Feb 7, 2018

@lkzhao Thank you for the quick response.

I just took a look at the master branch.

It's still being force unwrapped.

https://github.com/lkzhao/Hero/blob/master/Sources/HeroContext.swift#L212

@symbeus
Copy link

@symbeus symbeus commented Feb 13, 2019 •
edited

Same here

screenshot 2019-02-13 at 19 27 50

Did anyone solve this?

@wolfej94
Copy link

@wolfej94 wolfej94 commented Mar 30, 2021

This is still an issue https://github.com/lkzhao/Hero/blob/master/Sources/HeroContext.swift#L212

@JoeMatt JoeMatt reopened this Apr 1, 2021
@JoeMatt JoeMatt added this to the 1.7.0 milestone Apr 1, 2021
@JoeMatt
Copy link
Collaborator

@JoeMatt JoeMatt commented Apr 1, 2021

I'm a bit too busy to make and test a fix,
could someone in this thread please submit a PR with tests as a plus for quick review/merge.

I have this ear marked for 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed bug good first issue
Projects
None yet
Milestone
1.7.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet