The Wayback Machine - https://web.archive.org/web/20210119205019/https://github.com/codebuddies/codebuddies/issues/1098
Skip to content

/ codebuddies

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: study groups card needs height increase to avoid overflow #1098

Open
stain88 opened this issue Jan 1, 2019 · 9 comments
Open

Issue: study groups card needs height increase to avoid overflow #1098

stain88 opened this issue Jan 1, 2019 · 9 comments
Assignees
@akosasante
Labels
[feature] groups [state] backlog [type] bug claimed good first issue

Comments

@stain88
Copy link
Collaborator

@stain88 stain88 commented Jan 1, 2019

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
low_height

What is the expected behavior?
Bit more height to avoid the overflow on the bottom.

Which browser / OS are affected by this issue? (An isolated way to reproduce the bug)
FF/Safari/Chrome on Mac, so I'm guessing most.
@stain88
Copy link
Collaborator Author

@stain88 stain88 commented Jan 1, 2019

As a second tweak, I'd add a white-space: nowrap; on the small around the user class, to avoid that breaking on two lines:
split_user_count
@lpatmo
Copy link
Member

@lpatmo lpatmo commented Feb 16, 2019

I don't see a PR related to this but I think it looks fixed on codebuddies.org/groups now (and maybe I forgot to close). Feel free to re-open if I'm wrong!
@lpatmo lpatmo closed this Feb 16, 2019
@stain88 stain88 reopened this Feb 16, 2019
@stain88
Copy link
Collaborator Author

@stain88 stain88 commented Feb 16, 2019

Both issues are still present on all Mac browsers:

card issues
@lpatmo
Copy link
Member

@lpatmo lpatmo commented Feb 16, 2019

D'oh, you're right, not sure how I confused it with some other cards. Sorry!
@lpatmo lpatmo mentioned this issue Feb 17, 2019
Merged
@ghost ghost assigned lpatmo Feb 17, 2019
@ghost ghost added the [state] in-progress label Feb 17, 2019
@lpatmo lpatmo removed the [state] backlog label Feb 17, 2019
@lpatmo lpatmo closed this in #1115 Feb 17, 2019
@ghost ghost removed the [state] in-progress label Feb 17, 2019
@lpatmo lpatmo mentioned this issue Feb 17, 2019
Merged
@stain88 stain88 reopened this Feb 17, 2019
@stain88
Copy link
Collaborator Author

@stain88 stain88 commented Feb 17, 2019

So, "Large" windows are fine, "Small" windows are fine, but the 992-1200px range is still not quite there. "Readings in Computer Science and Technology" seems to be a particularly long one. But at exactly 992px width, this happens:

992px_cards
@lpatmo
Copy link
Member

@lpatmo lpatmo commented Feb 17, 2019

Ah wow, 992px exactly! I had to install a browser width chrome extension to capture that since I kept sliding the browser past 992px.
@billglover billglover changed the title STUDY GROUPS: card css could have more height Issue: study groups card needs height increase to avoid overflow Feb 25, 2019
@lpatmo lpatmo removed the html-css label Feb 28, 2019
@akosasante
Copy link
Contributor

@akosasante akosasante commented Oct 9, 2019

I'd like to take a look at this issue if it's still occurring 👋
@stain88
Copy link
Collaborator Author

@stain88 stain88 commented Oct 10, 2019

Yep, I'm still reproducing this at exactly 992px width, on several browsers.
All yours, @akosasante
@stain88 stain88 added the claimed label Oct 10, 2019
@stain88 stain88 assigned akosasante and unassigned lpatmo Oct 10, 2019
@akosasante akosasante mentioned this issue Oct 11, 2019
Closed
@akosasante
Copy link
Contributor

@akosasante akosasante commented Oct 11, 2019 •
edited

@lpatmo / @stain88 I've opened a PR with a resolution 😄 I may have mishandled my git-fu though, it looks like it brought in a bunch of extraneous commits :/

#1143
@akosasante akosasante mentioned this issue Oct 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosasante akosasante

Labels
[feature] groups [state] backlog [type] bug claimed good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@billglover @lpatmo @stain88 @akosasante
You can’t perform that action at this time.